Fix #8749: Misleading error message when joining a room

Hi, this is our fix for Issue #8749 (closed) 'Misleading error message joining a room'. The new if-clause inside error 404 helps to distinguish the errors 'remote-server-not-found' and 'item-not-found'.

Best Regards Sergii and Annika

Computer Science Students

changed the description

Hi, Thanks for the patch.

1/ there are automated tests in gitlab, just not activated by default for new cloned. I activated it for your cloned project, and ran it with success.

2/ The patch doesn't answer fully the ticket: "please print the verbose error message from the server", but I don't think it's a good idea. The error from server could be non-understandable for the user. So that sounds enough to me.

But please add "Fixes #8749 (closed)" in commit message so that ticket will be closed automatically

added 3 commits

• bad0da89...c1c2a92e - 2 commits from branch gajim:master
• ce1acdd2 - Merge remote-tracking branch 'upstream/master'

Compare with previous version

Thanks for activating the tests, asterix.

How can we change the commit message in a good way? The easiest fix we can think of is to do a minimal change in a comment and commit again. But that seems not very elegant.

Sorry, we are not overly experienced with git...

added 1 commit

• 2e7ef912 - MUC: Improve error messages

Compare with previous version

changed title from fixes Issue #8749: Misleading error message joining a room to Fix #8749: Misleading error message when joining a room

changed the description

added 1 commit

• 86f5953e - MUC: Improve error messages

Compare with previous version

hi,

the command you search for is git commit --amend also you can look into git rebase next time you want to alter history (reword commits, squash commits etc)

Git is probably the most used version control system right now, so it will definitely pay off the sooner you get into it. Also here a good guide for writing good commit messages and why it is important https://chris.beams.io/posts/git-commit/

I reworded the commit message for you for now.

Thanks for your contribution

mentioned in commit 54f4c36f

merged

Thank you very much for your patience, for first time contributors git is sometimes a little overwhelming.

Best Wishes

Sergii and Annika