MUCs: cannot display messages sent from the MUC bare JID
It's not clear to me if this should be considered invalid according to XEP-0045, but I think it makes sense for "system messages" (messages not sent by a user but by the MUC service/the room). I think that biboumi does something similar. Conversations is OK with this, using the room JID as a nickname.
FWIW, for XEP-0425, if moderated by=the room (bare) JID, it works fine (gajim use the room name as a pseudo nickname for the moderator, which is just what I would expect). I think a similar behaviour here (ie using the room name and possibly the room avatar) would be great here.
Versions:
- OS: Linux 5.10.0-21-amd64
- GTK Version: 3.24.36
- PyGObject Version: 3.42.2
- GLib Version : 2.74.5
- python-nbxmpp Version: 4.2.0
- Gajim Version: 1.7.1
Traceback
Traceback (most recent call last):
File "/app/lib/python3.10/site-packages/gajim/gtk/control.py", line 644, in _request_history
self.add_messages([row])
File "/app/lib/python3.10/site-packages/gajim/gtk/control.py", line 746, in add_messages
self._scrolled_view.add_message(
File "/app/lib/python3.10/site-packages/gajim/gtk/conversation/view.py", line 513, in add_message
message_row = MessageRow(
File "/app/lib/python3.10/site-packages/gajim/gtk/conversation/rows/message.py", line 138, in __init__
name_widget = NicknameLabel(name, from_us)
File "/app/lib/python3.10/site-packages/gajim/gtk/conversation/rows/widgets.py", line 95, in __init__
self.set_text(name)
TypeError: Argument 1 does not allow None as a value
Steps to reproduce the problem
- Find a MUC service that does this (send messages from the room bare JID), eg, a certain gateway component.
- Open the chat tab
...