Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G gajim-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 49
    • Issues 49
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gajim
  • gajim-plugins
  • Merge requests
  • !210

Merged
Created Apr 24, 2021 by Kamay@XutaxKamay

[pgp] Fixed file sharing feature.

  • Overview 3
  • Commits 2
  • Pipelines 3
  • Changes 2

Hello, this is a small patch for the PGP legacy plugin. There was a small problem when sending a file: The encrypt_file method from PGP module needed a stream (file instance) instead of bytes, it was probably due to some gajim updates when file.get_data was returning a file/stream. I guess this would need also to be updated on master but I couldn't do a pull request for multiple branches.

Also, I've just noticed now, but it doesn't seem to support decrypting files on the fly. Though, I'm not sure if I should contribute more to this plugin since XEP-0027 is now archived. Should I go instead for the new OpenPGP XEP-0373 plugin to support file sharing ?

I'm asking this because some others clients does not have yet the experimental XEP-0373, so I'm kinda hesitating. But maybe this would promote the newer XEP, so others clients implements it (Conversations for example).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: gajim_1.3