Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G gajim-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gajim
  • gajim-plugins
  • Merge requests
  • !201

Merged
Created Sep 08, 2020 by Vladislav Yarmak@yarmakContributor

[pgp] use full key fingerprints for identity bindings

  • Overview 20
  • Commits 9
  • Changes 3

Fixes #518

Highlights of changes introduced by this MR:

  • Introduces versioning in KeyStore database
  • Adds migration which resolves all short key IDs to the records corresponding fingerprints
  • Drops use of delay_execution because it causes interference between KeyStore instances belonging to different accounts, cancelling writes after migrations. Instead, we dispose need in such ratelimiting with *_nosync private methods used by bulk writes.
  • Modifies PGPLegacy.has_valid_key_assigned to make it match learned short fingerprint against key from KeyStore. Key learning is expected to be removed by fix for #519 (closed), so this is just to make everything work in current state.
Edited Sep 08, 2020 by Philipp Hörist
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_518