Skip to content
Snippets Groups Projects

[length_notifier] Fix counter for multiple chat controls

Merged Daniel Brötzmann requested to merge wurstsalat/gajim-plugins:message-lenght-fix into master
All threads resolved!

Fixes the counter when used in multiple chat controls. This also adds support for group chats.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Daniel Brötzmann

      This plugin could be improved

      1. Instead of storing data in the chat control length_notifier_plugin_data, create a Class that inherits from Gtk.Label() store all information in that class.

      2. connect to the buffer from that class, so on the callback you are already inside the Label and have all data available, so you dont have to pass the chat control to the callback and retrieve the data from the chat control

      3. Color change should be done via adding a css class and removing a css class, not via override_background_color which is deprecated

      4. Migrate to new style plugin config window

  • added 3 commits

    • e6d9790d - [length_notifier] Fix character counter
    • 0f9150a8 - [length_notifier] Enable plugin for group chats
    • 667e1c7b - [length_notifier] Update manifest.ini

    Compare with previous version

  • Philipp Hörist resolved all threads

    resolved all threads

  • mentioned in issue #473 (closed)

  • Daniel Brötzmann resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading