[omemo] TypeError: unhashable type: 'list'

added OMEMO label

closed via commit 850cf7d8

Perhaps a debug print leftover:

03/12/2019 19:17:52 (I) gajim.p.omemo            | (MYSERVER) Received device list for MYJID@MYSERVER: [1111111111]
03/12/2019 19:17:52 (I) gajim.p.omemo            | (MYSERVER) Saved devices for MYJID@MYSERVER
03/12/2019 19:17:55 (D) gajim.p.omemo            | <class 'omemo.plugin.OmemoPlugin'>

Strange, that after this fix I still cannot send OMEMO:

03/12/2019 19:19:25 (D) gajim.p.omemo            | MYSERVER => Sending Message to OTHERJID@MYSERVER
03/12/2019 19:19:25 (W) gajim.p.omemo            | (MYSERVER) No devices for encryption found for: OTHERJID@MYSERVER

despite of:

03/12/2019 19:17:50 (I) gajim.p.omemo            | (MYSERVER) Received device list for OTHERJID@MYSERVER: [999999999]
03/12/2019 19:17:50 (I) gajim.p.omemo            | (MYSERVER) Saved devices for OTHERJID@MYSERVER

do you have trusted fingerprints for the contact?

Yes, it was and remains trusted.

Would be great to have a bit more debug output during encryption / device discovering.

there is nothing more to output i think you have to put prints into

devices.py / _get_devices_for_encryption(), and look whats up there, maybe the trust determining db method fails somehow

Indeed, the device is not trusted. So UI must doing something different, if it shows the fingerprint as trusted.

UI:

    def getFingerprints(self, jid):
        query = '''SELECT recipient_id as "recipient_id [jid]",
                          public_key as "public_key [pk]",
                          trust,
                          timestamp
                   FROM identities
                   WHERE recipient_id = ? ORDER BY trust ASC'''
        return self._con.execute(query, (jid,)).fetchall()
...
    def _load_fingerprints(self, contact_jid, groupchat=False):
...
            results = self._omemo.backend.storage.getFingerprints(contact_jid)
        for result in results:
            rows[result.public_key] = KeyRow(result.recipient_id,
                                             result.public_key,
                                             result.trust,
                                             result.timestamp)

devices:

    def isTrusted(self, recipient_id, device_id):
        record = self.loadSession(recipient_id, device_id)
        if record.isFresh():
            return False
        identity_key = record.getSessionState().getRemoteIdentityKey()
        return self.getTrustForIdentity(
            recipient_id, identity_key) == Trust.TRUSTED

where does the isTrusted method exit, in the isFresh() or does self.getTrustForIdentity(recipient_id, identity_key) == Trust.TRUSTED return false?

what is the database value for trust for the device

It goes beyond isFresh(), so ... == Trust.TRUSTED must be false.

omemo_MYJID@MYSERVER.net.db --> identities --> 2 entries with the same recepient_id OTHERJID@MYSERVER with both trust = 1.

--> sessions --> the other device_id (which has lower "_id") is inactive.

self.getTrustForIdentity(recipient_id, identity_key) returns None

At the first glance it looks like it should find that trust is set to 1. So need to look deeper.

Its that sqlite bug, its because we search with the private key and its a byte blob, sometimes sqlite cant deal with that and just doesnt find it, i have to migrate that to saving the fingerprint as string

you can try to delete the fingerprint from the UI and get a new session

Yeah, I've printed them and visually it is OK, but I was not aware about such issues. Is it a known bug to sqlite devs or is it just a usage issue?

its to cumbersome to investigate this i just will switch to strings and it will work

sqlitebrowser states always: "Type of data currently in cell: Binary" but some public_key entries are displayed just as "BLOB" while others as string. Strange.

its to cumbersome to investigate this i just will switch to strings and it will work

OK.

mentioned in issue #402 (closed)

[omemo] TypeError: unhashable type: 'list'

Designs

Child items ...

Activity