Commit 72f65dad authored by BoySka's avatar BoySka Committed by Yann Leboulanger

[plugin_installer] SSL hardening

Only TLS >= v1.2 allowed, with no compression (we don't need it, as we
are only downloading zipfiles)
parent c444ff79
......@@ -32,6 +32,7 @@ import urllib2
import urlparse
import posixpath
import traceback
import ssl
import gtk
import pango
......@@ -139,11 +140,22 @@ class PluginInstaller(GajimPlugin):
uri = urlparse.urljoin(server, location)
log.debug('Fetching {}'.format(uri))
ssl_args = {}
if 'cafile' in inspect.getargspec(urllib2.urlopen).args:'You are using HTTPS CA pinning, very good!')
ssl_args['cafile'] = self.local_file_path('DST_Root_CA_X3.pem')
log.warning('Your python version does not support HTTPS CA pinning')
if hasattr(ssl, 'create_default_context'):
if 'cafile' in inspect.getargspec(ssl.create_default_context).args:
ssl_args['context'] = ssl.create_default_context(
log.warning('Your python version does not '
'support HTTPS CA pinning')
ssl_args['context'] = ssl.create_default_context()
for flag in ('OP_NO_SSLv2', 'OP_NO_SSLv3',
'OP_NO_TLSv1', 'OP_NO_TLSv1_1',
log.debug('Installer SSL: +%s' % flag)
if hasattr(ssl, flag):
ssl_args['context'].options |= getattr(ssl, flag)
request = urllib2.urlopen(uri, **ssl_args)
manifest_buffer = io.BytesIO(
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment