Commit fddb000a authored by junglecow's avatar junglecow
Browse files


 - In verbose mode, print encodings. (Especially for Windows users who don't have Python) (
 - Attempt at fixing traceback when getting user's home directory in Windows. See #2812. (c/
 - Show 'error' icon next to account while waiting for reconnect. Fixes #2786. (c/, c/, c/
 - Fix 100% CPU usage and hanging connection when server closes connection on us. (c/x/
 - Fix 'hanging' connection when server closes the connection on us before we can open the XML stream. (Disconnect handler didn't get called.) (c/x/
 - Change prints to logger calls, various enhancements to debug printing, reduce spam (c/x/
 - this → self (c/x/
 - Call _do_receive() once to collect error message from socket, when error flag is raised in scheduler. (c/x/
parent 8c78a14c
...@@ -123,8 +123,12 @@ class NBCommonClient(CommonClient): ...@@ -123,8 +123,12 @@ class NBCommonClient(CommonClient):
self.on_connect_failure(retry) self.on_connect_failure(retry)
def _on_connected(self): def _on_connected(self):
# connect succeeded, so no need of this callback anymore # FIXME: why was this needed? Please note that we're working
self.on_connect_failure = None # in nonblocking mode, and this handler is actually called
# as soon as connection is initiated, NOT when connection
# succeeds, as the name suggests.
# # connect succeeded, so no need of this callback anymore
# self.on_connect_failure = None
self.connected = 'tcp' self.connected = 'tcp'
if self._Ssl: if self._Ssl:
transports_nb.NonBlockingTLS().PlugIn(self, now=1) transports_nb.NonBlockingTLS().PlugIn(self, now=1)
This diff is collapsed.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment