1. 30 Mar, 2017 5 commits
    • Markus Böhme's avatar
      Use the same named tuple for related methods for conversation loading · 21d15dec
      Markus Böhme authored
      Both methods get_conversation_for_date and search_log in the logger
      module are related to the loading of conversations and both return a
      list of messages from the log. Therefore, it makes sense that both of
      them have the same return type.
      
      Remove the named tuple type specific to search_log and convert the
      method to return tuples of type Message instead. As a side effect of
      this change, search_log now also returns values from the additional_data
      column in the log database.
      21d15dec
    • Markus Böhme's avatar
      Make conversation loading in the history window use named tuples · e735bfe7
      Markus Böhme authored
      The logger method get_conversation_for_date has previously been
      converted to return a list of named tuples. Now pass these tuples on to
      the method that actually inserts the conversation's messages into the
      textbuffer. Also rename two related methods in the history window:
        -  _add_lines_for_date => _load_conversation
        -  _add_new_line => _add_message
      e735bfe7
    • Markus Böhme's avatar
      Convert get_conversation_for_date to return named tuples · 65e926c1
      Markus Böhme authored
      The get_conversation_for_date method in the logger module returns a
      list of bare tuples. Knowledge of how to pack and unpack the many
      individual components of the tuples is split between the caller and
      the callee, making the method hard to maintain and ugly to use.
      Therefore, convert the method to return named tuple instead.
      65e926c1
    • Markus Böhme's avatar
      08f4e171
    • Markus Böhme's avatar
      Convert get_search_results_for_query to return named tuples · d612e80a
      Markus Böhme authored
      The get_search_results_for_query method in the logger module returns a
      list of bare tuples. Knowledge of how to pack and unpack the many
      indidual components of the tuples is scattered across both the callers
      and the callee, making the method hard to maintain and ugly to use.
      Therefore, convert the method to return named tuples instead.
      d612e80a
  2. 29 Mar, 2017 2 commits
  3. 27 Mar, 2017 2 commits
  4. 26 Mar, 2017 1 commit
  5. 25 Mar, 2017 4 commits
    • Philipp Hörist's avatar
      Merge branch 'fix-additional_data-loading' into 'master' · 6b34ea95
      Philipp Hörist authored
      Fix loading of additional_data column from log database
      
      See merge request !72
      6b34ea95
    • Markus Böhme's avatar
      Fix loading of additional_data column from log database · d9ab39b0
      Markus Böhme authored
      Currently, the additional_data column is not correctly loaded from the
      log database in the logger module's methods get_last_conversation_lines
      and get_conversation_for_date. While the JSON data in the column is
      parsed, the parsed value is not saved, because the code assumes that
      changes to a loop variable are reflected in the list that is iterated
      over. Instead, the unparsed JSON string is returned. Fix this by building
      a separate list with the JSON string replaced by the parsed JSON object.
      d9ab39b0
    • Philipp Hörist's avatar
      Merge branch 'issue-8548-master' into 'master' · fbb19c5c
      Philipp Hörist authored
      Fix issue #8548 on master: Do not close chat window on ESC key when roster filtering is active
      
      Closes #8548
      
      See merge request !74
      fbb19c5c
    • Markus Böhme's avatar
      Do not close chat window on ESC key when roster filtering is active · c8e990f8
      Markus Böhme authored
      When the roster window active it can be filtered by starting to type.
      If the window behavior "single window for everything" is selected,
      trying to abort the filtering by pressing the ESC key also closes a chat
      window. Fix this behavior by stopping event propagation in case the ESC
      key is pressed while roster filtering is active.
      
      Fixes issue #8548.
      c8e990f8
  6. 24 Mar, 2017 1 commit
  7. 14 Mar, 2017 11 commits
  8. 13 Mar, 2017 3 commits
  9. 11 Mar, 2017 5 commits
  10. 08 Mar, 2017 2 commits
  11. 07 Mar, 2017 4 commits