Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
P
python-nbxmpp
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gajim
  • python-nbxmpp
  • Issues
  • #38

Closed
Open
Opened Sep 29, 2016 by NooN8@NooN8
  • Report abuse
  • New issue
Report abuse New issue

Multiple small fixup

Some small fixups I made. They have to be reviewed,

Patches:

  • clearstyle: The try to make the really dense code more readable
  • hideinternname: Name hides an intern name => renamed it
  • comment: adapt different comment styles to make them equal
  • null: Checks with None should be made with is oder is not. see http://pythoncentral.io/python-null-equivalent-none/
  • addsub: simplify arithmetic
  • notin: checks if something is not in a list/dict/.. should be done with 'var not in list'
  • object: make all classes inherit from object

This is the biggest:

  • parametermutable: make all parameter immutable. If you use [] or {} as a default parameter funny things can happen. there will only be one default list per function parameter. if this gets changed in all subsequent calls to the function the changed default parameter will be used. So this patch changes the behaviour to the one I think was intended
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: gajim/python-nbxmpp#38