Multiple JID related bugs
Versions
- OS: Manjaro
- Gajim version: 1.1.92+1165bde2
- GTK version: 3.24.9
- Python-nbxmpp version: 0.9.91+python-nbxmpp@3946f35b
Steps to reproduce the problem
- Try to join a group chat via ServiceDiscovery window
Expected behavior
Join group chat.
Actual behavior
Traceback (most recent call last):
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gtk/discovery.py", line 768, in _on_services_treeview_row_activated
self.browser.default_action()
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gtk/discovery.py", line 1781, in default_action
self._on_join_button_clicked()
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gtk/discovery.py", line 1766, in _on_join_button_clicked
app.interface.join_gc_minimal(self.account, service)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gui_interface.py", line 1426, in join_gc_minimal
account, bookmark.jid, bookmark.nick, bookmark.password)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gui_interface.py", line 1622, in join_gc_room
is_continued=is_continued)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gui_interface.py", line 1646, in new_room
is_continued=is_continued)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/groupchat_control.py", line 176, in __init__
self.name = bm_module.get_name_from_bookmark(self.room_jid)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/common/modules/bookmarks.py", line 227, in get_name_from_bookmark
fallback = jid.split('@')[0]
AttributeError: 'JID' object has no attribute 'split'
After that, other JID related errors start to appear
When leaving a group chat via roster or hovering over a contact:
Traceback (most recent call last):
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/roster_window.py", line 5467, in query_tooltip
row, connected_contacts, account, typ)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gtk/tooltips.py", line 294, in get_tooltip
self._populate_grid(connected_contacts, account, typ)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gtk/tooltips.py", line 325, in _populate_grid
contacts.get_nb_online_total_contacts(accounts=[account])
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/common/contacts.py", line 446, in get_nb_online_total_contacts
if (common.app.jid_is_transport(jid) and
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/common/app.py", line 540, in jid_is_transport
if jid.find('@') <= 0:
AttributeError: 'JID' object has no attribute 'find'
When right clicking a contact:
Traceback (most recent call last):
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/roster_window.py", line 3237, in on_roster_treeview_button_press_event
return self.show_treeview_menu(event)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/roster_window.py", line 5401, in show_treeview_menu
self.show_appropriate_context_menu(event, iters)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/roster_window.py", line 5379, in show_appropriate_context_menu
self.make_contact_menu(event, iters[0])
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/roster_window.py", line 5103, in make_contact_menu
menu = gui_menu_builder.get_contact_menu(contact, account)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gui_menu_builder.py", line 368, in get_contact_menu
force_resource=force_resource)
File "/mnt/Daten/Daten/Projekte/DEV/Gajim/gajim/gajim/gui_menu_builder.py", line 185, in build_invite_submenu
menuitem = Gtk.MenuItem.new_with_label(room_jid.getNode())
AttributeError: 'str' object has no attribute 'getNode'