redesign the ad-hoc dialog
the current ad-hoc dialog is just ugly (sorry, but it looks totally strange compared to other dialogs in gajim which follow the HIG mostly):
-
the "cancel" button on the left makes this dialog look strange compared with the other dialogs used in gajim. you should use a "close" button in the lower right corner instead with spacing before it.
-
the "forward" button should replace the "execute button". (i'm currently only testing ad-hoc with an icq transport, so this is where i take my experiences from) when you select an action that changes to another step in the dialog (like look up users by email), the forward button is to be used, which makes sense. in the next dialog, execute is used. makes sense too. however, when the selected action directly executes the command, execute is not used, but forward (like in pyicqt statistics) which does not make sense. since always only one action can be used, i suggest you show only one button, that takes you to the next step. whether this is forward or execute should be context sensitive, but showing both and have them not behave in a consistent way isn't good.
-
remove the "back" button, as it does nothing anyway. even with a command like "look up users via email", where "forward" takes you to the next step, "back" is not enabled. instead you can only "cancel", which asks you if you really want to cancel. you should replace cancel with close anyway (which should not ask for confirmation) and show "cancel" only, when the task is in progress. there it also makes sense to ask for confirmation of cancelling the operation. mabye "back" made sense if it actually could be used to bring you back to the last step, but as it does nothing atm and is always disabled, either remove it or make it work.
-
in "show pyicq-t statistics", the descriptions of the numbers right to th numbers are aligned centered, which looks totally bad. they should be aligned left too. also the window size needs to be changed to show the whole window as horizontal scrollbars are bad. the information is hidden for the user at first and you have to scroll to view it. baaaad.
not about redesign, but
- only open the dialog once for a specific resource if possible. atm it can be opened multiple times for the same resource.