gajim issueshttps://dev.gajim.org/gajim/gajim/-/issues2017-12-11T16:38:56Zhttps://dev.gajim.org/gajim/gajim/-/issues/7842Error message when opening plugins2017-12-11T16:38:56ZanonymousError message when opening pluginsWhen I open plugins I get the following message:
Traceback (most recent call last):
File "/home/USERNAME/.local/share/gajim/plugins/plugin_installer/plugin_installer.py", line 390, in available_plugins_treeview_selec...When I open plugins I get the following message:
Traceback (most recent call last):
File "/home/USERNAME/.local/share/gajim/plugins/plugin_installer/plugin_installer.py", line 390, in available_plugins_treeview_selection_changed
self.plugin_description_textview)
TypeError: display_html() takes at least 4 arguments (3 given)
The plugin installation process seems to work, so I think it's a minor bug.0.16.1https://dev.gajim.org/gajim/gajim/-/issues/8038Error window shows up when chat window is opened2018-04-29T20:37:35ZanonymousError window shows up when chat window is opened# Bug description
"It is probably not fatal, but should be reported to the developers nonetheless."
So I report. :-)
An error window appears, but I can type anyway, can't see any other
effects. The window is rather annoying though... :...# Bug description
"It is probably not fatal, but should be reported to the developers nonetheless."
So I report. :-)
An error window appears, but I can type anyway, can't see any other
effects. The window is rather annoying though... :-)
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nbxmpp/dispatcher_nb.py", line 497, in dispatch
handler['func'](session, stanza)
File "/usr/share/gajim/src/common/connection_handlers.py", line 1868, in _messageCB
conn=self, stanza=msg, account=self.name))
File "/usr/share/gajim/src/common/nec.py", line 76, in push_incoming_event
self._generate_events_based_on_incoming_event(event_object)
File "/usr/share/gajim/src/common/nec.py", line 98, in _generate_events_based_on_incoming_event
if new_event_object.generate():
File "/usr/share/gajim/src/common/connection_handlers_events.py", line 1159, in generate
self.session.handle_negotiation(form)
File "/usr/share/gajim/src/session.py", line 482, in handle_negotiation
self.accept_e2e_alice(form, negotiated)
File "/usr/share/gajim/src/common/stanza_session.py", line 956, in accept_e2e_alice
rshashes.append(crypto.random_bytes(rshash_size))
File "/usr/share/gajim/src/common/crypto.py", line 122, in random_bytes
OpenSSL.rand.add(os.urandom(bytes_), bytes_)
File "/usr/lib/python2.7/dist-packages/OpenSSL/rand.py", line 64, in add
raise TypeError("entropy must be an integer")
TypeError: entropy must be an integer
# Steps to reproduce
Usually when I start a chat window
# Software versions
OS version:
Linux 3.16-2-amd64 #1 SMP Debian 3.16.3-2 (2014-09-20) x86_64 GNU/Linux
(Debian sid)
GTK version:
3.14.5-1
PyGTK version:
2.24.0-4
0.16.1https://dev.gajim.org/gajim/gajim/-/issues/7983Bug with shortcut [Ctrl + J] and add groupchat window2018-04-29T20:37:37ZanonymousBug with shortcut [Ctrl + J] and add groupchat window# Bug description
Groupchat window is compressed to a little square.
After "uncompressing" the window it's blank.
# Steps to reproduce
Hit Ctrl + J.
Select account.
Destroy Window or cancel.
Hit Ctrl + J.
Now the window is a "little squ...# Bug description
Groupchat window is compressed to a little square.
After "uncompressing" the window it's blank.
# Steps to reproduce
Hit Ctrl + J.
Select account.
Destroy Window or cancel.
Hit Ctrl + J.
Now the window is a "little square".
You have to select an account!
The Dialog is still available using menu.
Only the shortcut shows the "little square".
# Software versions
OS version: XUbuntu 14.10
GTK version: 2.24.25
PyGTK version: 2.24.0
Gajim Version: Gajim 0.16-e4b211e92f940.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7981punycode applied the wrong way2018-04-29T20:37:37Zanonymouspunycode applied the wrong way# Bug description
when a URI / IRI with non-ascii characters is received, punycode encoding gets applied the wrong way, resulting in URIs that can not be resolved. this affects two areas:
* domain name conversion: the prefix is not add...# Bug description
when a URI / IRI with non-ascii characters is received, punycode encoding gets applied the wrong way, resulting in URIs that can not be resolved. this affects two areas:
* domain name conversion: the prefix is not added and the calculated suffix is wrong. while http://öpnv-karte.de should be http://xn--pnv-karte-z7a.de according to the epiphany browser and the converter at http://www.charset.org/punycode.php, gajim displays it as http://pnv-karte.de-w6b
* the punycode escaping gets applied even inside the path component, where there is no punycoding defined, and common practice is to percent-escape the URI created from the unicode IRI entered. http://example.com/schön should be http://example.com/sch%C3%B6n, but gajim displays it as http://example.com/schn-tlc
# Steps to reproduce
* send one of the abovementioned IRIs to yourself via gajim
* watch the xml console: on the wire, they appear as unicode strings without the added punycode explanation
* look at what gets received: the address displayed as hyperlink as well as the link attached to it are the original IRI, but the URI displayed in parentheses after is nonsentical.
# Software versions
OS version: Debian GNU/Linux sid
GTK version: 2.24.25-1
PyGTK version: 2.24.0-40.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7973Use bare JID when checking MAM message recipient2018-04-29T20:37:37ZanonymousUse bare JID when checking MAM message recipient# Bug description
While figuring out the recipient of a MAM message, Gajim forgets to strip the resource from the JID (or rather to assign the result of stripping the resource). In the end, Gajim won't show MAM messages that were sent ...# Bug description
While figuring out the recipient of a MAM message, Gajim forgets to strip the resource from the JID (or rather to assign the result of stripping the resource). In the end, Gajim won't show MAM messages that were sent to a non-bare JID of the local account. The attached patch fixes the issue.
# Steps to reproduce
Use a server that supports MAM, receive a message to some non-bare JID while Gajim is offline but another resource is online, and then go online with Gajim. Gajim should now receive the message via MAM, but it won't show the message.0.16.1anonymousanonymoushttps://dev.gajim.org/gajim/gajim/-/issues/7971mutable default arguments2018-04-29T20:37:37Zanonymousmutable default argumentsyou use mutable default args rather often and this triggers warnings in linters.
as long as you do not really mutate them, this is not causing real issues, but you should rather use None (or no default argument) there.
here is a case w...you use mutable default args rather often and this triggers warnings in linters.
as long as you do not really mutate them, this is not causing real issues, but you should rather use None (or no default argument) there.
here is a case where it might really cause issues:
client_zeroconf.py:131 stanzaqueue - you later modify that list, so the default argument for the next instanciation won't be what you thought it would be, likely. as you always gave that argument, you did not run into that yet, but then you could also leave the default away.
socks5.py:922 wrong (and mutable) default value for file_props (you can't set attributes on a dict object).
check also 1334, 1344, 1352, 1363.
0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7970bad property definition2018-04-29T20:37:37Zanonymousbad property definitiondisco.py:595
it looks like you wanted 1 property with a getter and a setter there, but that can't be done like you see there.
just putting @property in front of it makes it a getter (not a setter).
disco.py:595
it looks like you wanted 1 property with a getter and a setter there, but that can't be done like you see there.
just putting @property in front of it makes it a getter (not a setter).
0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7969bad except clauses order2018-04-29T20:37:37Zanonymousbad except clauses orderlogger.py:416
try:
self.cur.execute(sql, values)
except sqlite.DatabaseError:
raise exceptions.DatabaseMalformed
except sqlite.OperationalError as e:
raise exceptions.PysqliteO...logger.py:416
try:
self.cur.execute(sql, values)
except sqlite.DatabaseError:
raise exceptions.DatabaseMalformed
except sqlite.OperationalError as e:
raise exceptions.PysqliteOperationalError(str(e))
DatabaseError is a superclass of OperationalError, so this does not work in that order.
0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7966mix of tabs and spaces in zeroconf_avahi.py2018-04-29T20:37:38Zanonymousmix of tabs and spaces in zeroconf_avahi.pyline 281 and 282line 281 and 2820.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7965format char missing2018-04-29T20:37:38Zanonymousformat char missingroster_window.py:572
assert old_big_jid, 'No Big Brother in nearby family % (Family: %)' % (nearby_family, family)
you meant %s (twice) maybe?roster_window.py:572
assert old_big_jid, 'No Big Brother in nearby family % (Family: %)' % (nearby_family, family)
you meant %s (twice) maybe?0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7964duplicate dict keys2018-04-29T20:37:38Zanonymousduplicate dict keyshelpers.py distro_info assigns different values to identical keys which obviously can't work.
keys:
Debian GNU/Linux
Slackware Linuxhelpers.py distro_info assigns different values to identical keys which obviously can't work.
keys:
Debian GNU/Linux
Slackware Linux0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7956"A programming error has been detected" OpenSSL2018-04-29T20:37:39Zanonymous"A programming error has been detected" OpenSSL# Bug description
Opened a new tab in conversation window, and got the following error in a new window
("A programming error has been detected")
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packag...# Bug description
Opened a new tab in conversation window, and got the following error in a new window
("A programming error has been detected")
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nbxmpp/dispatcher_nb.py", line 497, in dispatch
handler['func'](session, stanza)
File "/usr/share/gajim/src/common/connection_handlers.py", line 1868, in _messageCB
conn=self, stanza=msg, account=self.name))
File "/usr/share/gajim/src/common/nec.py", line 76, in push_incoming_event
self._generate_events_based_on_incoming_event(event_object)
File "/usr/share/gajim/src/common/nec.py", line 98, in _generate_events_based_on_incoming_event
if new_event_object.generate():
File "/usr/share/gajim/src/common/connection_handlers_events.py", line 1159, in generate
self.session.handle_negotiation(form)
File "/usr/share/gajim/src/session.py", line 482, in handle_negotiation
self.accept_e2e_alice(form, negotiated)
File "/usr/share/gajim/src/common/stanza_session.py", line 956, in accept_e2e_alice
rshashes.append(crypto.random_bytes(rshash_size))
File "/usr/share/gajim/src/common/crypto.py", line 122, in random_bytes
OpenSSL.rand.add(os.urandom(bytes_), bytes_)
File "/usr/lib/python2.7/dist-packages/OpenSSL/rand.py", line 64, in add
raise TypeError("entropy must be an integer")
TypeError: entropy must be an integer
I am using the OTR plugin, if it matters.
# Steps to reproduce
None
# Software versions
OS version: Debian Jessie
GTK version: libgtk2.0-0 2.24.25-1
PyGTK version: python-gtk2 2.24.0-40.16.1https://dev.gajim.org/gajim/gajim/-/issues/7953Metadata in Chatlogs even for encrypted OTR messages2018-04-29T20:37:39ZanonymousMetadata in Chatlogs even for encrypted OTR messages# Bug description
For OTR connections (using plugin) the following message is found in the History Log, even when all logging is disabled:
19.01.2015 [OTR: authenticated secured OTR conversation with \<user@server/key> started]
This is a...# Bug description
For OTR connections (using plugin) the following message is found in the History Log, even when all logging is disabled:
19.01.2015 [OTR: authenticated secured OTR conversation with \<user@server/key> started]
This is a serious security vulnerability affecting plausible deniability of OTR connections. There should be no logs saved about an OTR connection.
# Steps to reproduce
Start a secured conversation using the OTR plugin. Open the
History Logs Manager
# Software versions
OS version: Windows 7 SP1
GTK version: 2.24.10
PyGTK version: 2.24.00.16.1https://dev.gajim.org/gajim/gajim/-/issues/7917A programming error has been detected2018-04-29T20:37:39ZanonymousA programming error has been detectedgajim 0.16-1 (debian sid)
# Bug description
"It is probably not fatal, but should be reported to the developers nonetheless."
So I report it. :-)
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nbxmpp/disp...gajim 0.16-1 (debian sid)
# Bug description
"It is probably not fatal, but should be reported to the developers nonetheless."
So I report it. :-)
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nbxmpp/dispatcher_nb.py", line 497, in dispatch
handler['func'](session, stanza)
File "/usr/share/gajim/src/common/connection_handlers.py", line 1868, in _messageCB
conn=self, stanza=msg, account=self.name))
File "/usr/share/gajim/src/common/nec.py", line 76, in push_incoming_event
self._generate_events_based_on_incoming_event(event_object)
File "/usr/share/gajim/src/common/nec.py", line 98, in _generate_events_based_on_incoming_event
if new_event_object.generate():
File "/usr/share/gajim/src/common/connection_handlers_events.py", line 1159, in generate
self.session.handle_negotiation(form)
File "/usr/share/gajim/src/session.py", line 482, in handle_negotiation
self.accept_e2e_alice(form, negotiated)
File "/usr/share/gajim/src/common/stanza_session.py", line 956, in accept_e2e_alice
rshashes.append(crypto.random_bytes(rshash_size))
File "/usr/share/gajim/src/common/crypto.py", line 122, in random_bytes
OpenSSL.rand.add(os.urandom(bytes_), bytes_)
File "/usr/lib/python2.7/dist-packages/OpenSSL/rand.py", line 64, in add
raise TypeError("entropy must be an integer")
TypeError: entropy must be an integer
# Steps to reproduce
Writing something in a chat sometimes gives this error.
Nothing is affected as far as I can see, the text is entered as it should.
# Software versions
3.16-2-amd64, debian sid
libgtk2.0-0:amd64 is 2.24.25-1
python-gtk2 is 2.24.0-4
0.16.1https://dev.gajim.org/gajim/gajim/-/issues/7912Installation of pygtk not working2018-04-30T11:42:43ZanonymousInstallation of pygtk not working# problem
# analysis
# enhancement recommendation
I am running on Windows (64bit version) and have python 2.7 (also 64 bit) installed. I downloaded the all-in-one installer for pygtk for python 2.7, but when I run it, it shows "python ...# problem
# analysis
# enhancement recommendation
I am running on Windows (64bit version) and have python 2.7 (also 64 bit) installed. I downloaded the all-in-one installer for pygtk for python 2.7, but when I run it, it shows "python 2.7 could not be located on your system". Why is it so when I already have python 2.7 installed?0.16.1https://dev.gajim.org/gajim/gajim/-/issues/7851Fix gajim-history-manager.1 manpage (missing end lists)2018-04-29T20:37:42ZanonymousFix gajim-history-manager.1 manpage (missing end lists)Hello,
I have noticed errors in the manpage data/gajim-history-manager.1: two lists begin with .Bl (begin list) but have no matching .El (end list). I will attach a patch that fixes that.Hello,
I have noticed errors in the manpage data/gajim-history-manager.1: two lists begin with .Bl (begin list) but have no matching .El (end list). I will attach a patch that fixes that.0.16.1https://dev.gajim.org/gajim/gajim/-/issues/7838Useless buttons in balloon notifications2018-04-30T11:44:40ZDarlanUseless buttons in balloon notifications# problem
Buttons of balloon notifications are useless.
# analysis
When avahi-daemon is disabled, Gajim would show a balloon notification saying "Could not start local service" with a button "Connection Failed" (see attached image); tha...# problem
Buttons of balloon notifications are useless.
# analysis
When avahi-daemon is disabled, Gajim would show a balloon notification saying "Could not start local service" with a button "Connection Failed" (see attached image); that button does not do anything. On the other hand, when Claws Mail notifies on new email, it has an interactive button "Present main window" which, on click, opens the main window of Claw Mail (see attached image).
# enhancement recommendation
Make buttons of balloon notifications useful.
For the above notification, I suggest to add a button "Open configuration" or "Reconfigure" or "Settings" or "Setup" which would open settings of= problem =
Buttons of balloon notifications are useless.
# analysis
When avahi-daemon is disabled, Gajim would show a balloon notification saying "Could not start local service" with a button "Connection Failed" (see attached image); that button does not do anything. On the other hand, when Claws Mail notifies on new email, it has an interactive button "Present main window" which, on click, opens the main window of Claw Mail (see attached image).
# enhancement recommendation
Make buttons of balloon notifications useful.
For the above notification, I suggest to add a button "Open configuration" or "Reconfigure" or "Settings" or "Setup" which would open settings of Local account.
For notifications of Jabber/XMPP accounts, I suggest to add two buttons:
* Try again
* "Open configuration" or...
Local account.
For notifications of Jabber/XMPP accounts, I suggest to add two buttons:
* Try again
* "Open configuration" or...
0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7711Roster broken when deactivate / activate an account2018-04-29T20:37:45ZanonymousRoster broken when deactivate / activate an account# Bug description
When deactivating and reactivating an account, the roster is no longer displayed when connected. The number of online users is correct.
# Steps to reproduce
- Disconnect
- Deactivate
- Reactivate
- Reconnect# Bug description
When deactivating and reactivating an account, the roster is no longer displayed when connected. The number of online users is correct.
# Steps to reproduce
- Disconnect
- Deactivate
- Reactivate
- Reconnect0.16.1Yann LeboulangerYann Leboulangerhttps://dev.gajim.org/gajim/gajim/-/issues/7628Support SHA-2 for SSL certificate fingerprints2018-04-30T11:42:43Zfedor.brunnerSupport SHA-2 for SSL certificate fingerprints# problem
Gajim checks and displays only SHA-1 for SSL certificate fingerprints. There have been reported weaknesses in SHA-1. Upgrade to support SHA-2.
# analysis
In 2005, cryptanalysts found attacks on SHA-1 suggesting that the algo...# problem
Gajim checks and displays only SHA-1 for SSL certificate fingerprints. There have been reported weaknesses in SHA-1. Upgrade to support SHA-2.
# analysis
In 2005, cryptanalysts found attacks on SHA-1 suggesting that the algorithm might not be secure enough for ongoing use.
https://www.schneier.com/blog/archives/2005/02/cryptanalysis_o.html
NIST required many applications in federal agencies to move to SHA-2 after 2010 because of the weakness.
http://csrc.nist.gov/groups/ST/toolkit/secure_hashing.html
In 2013 Microsoft announced their deprecation policy on SHA-1 according to which Windows will stop accepting SHA-1 certificates in SSL by 2017.
http://blogs.technet.com/b/pki/archive/2013/11/12/sha1-deprecation-policy.aspx
# enhancement recommendation
Add support for SHA2-256 fingerprints.
Add config option `ssl_fingerprint_sha256` and code for checking and GUI.0.16.1fedor.brunnerfedor.brunnerhttps://dev.gajim.org/gajim/gajim/-/issues/7911Integer entropy error (prob. OTR plugin)2018-04-30T11:40:50ZanonymousInteger entropy error (prob. OTR plugin)# Bug description
Seems to be a bug related to the OTR plugin:
*Message 1)*
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nbxmpp/dispatcher_nb.py", line 497, in dispatch
handler...# Bug description
Seems to be a bug related to the OTR plugin:
*Message 1)*
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nbxmpp/dispatcher_nb.py", line 497, in dispatch
handler['func'](session, stanza)
File "/usr/lib/python2.7/site-packages/gajim/common/connection_handlers.py", line 1868, in _messageCB
conn=self, stanza=msg, account=self.name))
File "/usr/lib/python2.7/site-packages/gajim/common/nec.py", line 76, in push_incoming_event
self._generate_events_based_on_incoming_event(event_object)
File "/usr/lib/python2.7/site-packages/gajim/common/nec.py", line 98, in _generate_events_based_on_incoming_event
if new_event_object.generate():
File "/usr/lib/python2.7/site-packages/gajim/common/connection_handlers_events.py", line 1159, in generate
self.session.handle_negotiation(form)
File "/usr/lib/python2.7/site-packages/gajim/session.py", line 482, in handle_negotiation
self.accept_e2e_alice(form, negotiated)
File "/usr/lib/python2.7/site-packages/gajim/common/stanza_session.py", line 956, in accept_e2e_alice
rshashes.append(crypto.random_bytes(rshash_size))
File "/usr/lib/python2.7/site-packages/gajim/common/crypto.py", line 122, in random_bytes
OpenSSL.rand.add(os.urandom(bytes_), bytes_)
File "/usr/lib/python2.7/site-packages/OpenSSL/rand.py", line 64, in add
raise TypeError("entropy must be an integer")
TypeError: entropy must be an integer
*Message 2)*
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/gajim/dialogs.py", line 1680, in on_response_yes
self.user_response_yes(self.is_checked())
File "/usr/lib/python2.7/site-packages/gajim/session.py", line 457, in accept_nondefault_options
self.accept_e2e_alice(form, negotiated)
File "/usr/lib/python2.7/site-packages/gajim/common/stanza_session.py", line 956, in accept_e2e_alice
rshashes.append(crypto.random_bytes(rshash_size))
File "/usr/lib/python2.7/site-packages/gajim/common/crypto.py", line 122, in random_bytes
OpenSSL.rand.add(os.urandom(bytes_), bytes_)
File "/usr/lib/python2.7/site-packages/OpenSSL/rand.py", line 64, in add
raise TypeError("entropy must be an integer")
TypeError: entropy must be an integer
It seems that the bug could be quite critical. Entropy is as far as I know critical to cryptography although I cannot say that this is a critical problem here.
# Steps to reproduce
No idea. The first time my friend connected message 1) appeared.
He reconnected and meassage 2) was shown.
# Software versions
OS version:
latest Arch linux (rolling release)
kernel: 3.18.1-1-ARCH
GTK versions:
-2.24.25-1
-3.14.6-1
PyGTK version:
2.24.0-50.16.1