Commit 3e362874 authored by Philipp Hörist's avatar Philipp Hörist

Detect invalid user activity

parent 7c7df9d4
Pipeline #2981 passed with stages
in 3 minutes and 36 seconds
......@@ -65,6 +65,9 @@ class UserActivity(AbstractPEPModule):
if activity_tag is None:
raise StanzaMalformed('No activity node')
if not activity_tag.getChildren():
return None
for child in activity_tag.getChildren():
name = child.getName().strip()
data = child.getData().strip()
......@@ -76,17 +79,22 @@ class UserActivity(AbstractPEPModule):
subactivity_name = subactivity.getName().strip()
activity_dict['subactivity'] = subactivity_name
return activity_dict or None
if 'activity' not in activity_dict:
raise StanzaMalformed('No activity value found')
return activity_dict
def _build_node(self, data):
item = nbxmpp.Node('activity', {'xmlns': self.namespace})
if data is None:
return item
activity, subactivity, message = data
if activity:
i = item.addChild(activity)
if subactivity:
if not activity:
return item
i = item.addChild(activity)
if subactivity:
if message:
i = item.addChild('text')
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment