gajim merge requestshttps://dev.gajim.org/gajim/gajim/-/merge_requests2021-12-04T21:18:42Zhttps://dev.gajim.org/gajim/gajim/-/merge_requests/770GUI Rework2021-12-04T21:18:42ZPhilipp Höristphilipp@hoerist.comGUI Rework1.4.0https://dev.gajim.org/gajim/gajim/-/merge_requests/1005Draft: Use an encryption default for MUCs. Closes #117492024-02-07T09:36:02ZMarcin MielniczukDraft: Use an encryption default for MUCs. Closes #11749https://dev.gajim.org/gajim/gajim/-/merge_requests/996Fix: HTTPS verification for preview and http file upload2024-03-10T22:34:54ZGhost UserFix: HTTPS verification for preview and http file uploadSee #11683.
Requires MR !77 in python-nbxmpp.
Added condition to check for option preview_verify_https in httpupload.py.
Removed get_user_data() in both files (empty if https verification is enabled and certificate is untrusted).
Fin...See #11683.
Requires MR !77 in python-nbxmpp.
Added condition to check for option preview_verify_https in httpupload.py.
Removed get_user_data() in both files (empty if https verification is enabled and certificate is untrusted).
Finally, the option `preview_verify_https` works fine again, enabled and disabled, for both http file upload and preview.https://dev.gajim.org/gajim/gajim/-/merge_requests/991fix: AttributeError on bare MUC presence2023-11-04T18:04:11ZNicocofix: AttributeError on bare MUC presenceThis is me fixing a bug I introduced. MUCs send bare presences with vcard-temp payload for their avatars, resulting in some AttributeError in gajim's log.This is me fixing a bug I introduced. MUCs send bare presences with vcard-temp payload for their avatars, resulting in some AttributeError in gajim's log.https://dev.gajim.org/gajim/gajim/-/merge_requests/987fix: dev env setup script2023-10-09T17:39:11ZNicocofix: dev env setup scriptWithout these changes, `./scripts/dev_env.sh` fails with:
> ERROR: Project file:///home/nicoco/src/perso/xmpp/gajim has a 'pyproject.toml' and its build backend is missing the 'build_editable' hook. Since it does not have a 'setup.py' n...Without these changes, `./scripts/dev_env.sh` fails with:
> ERROR: Project file:///home/nicoco/src/perso/xmpp/gajim has a 'pyproject.toml' and its build backend is missing the 'build_editable' hook. Since it does not have a 'setup.py' nor a 'setup.cfg', it cannot be installed in editable mode. Consider using a build backend that supports PEP 660.
Maybe we need to do something more subtle somewhere, but this seems to work.https://dev.gajim.org/gajim/gajim/-/merge_requests/981Change 'Topic' to 'Subject' in Group Chat Details.2023-10-03T06:10:21Zdiode24Change 'Topic' to 'Subject' in Group Chat Details.We should use a consistent label for the MUC Subject throughout the UI.We should use a consistent label for the MUC Subject throughout the UI.https://dev.gajim.org/gajim/gajim/-/merge_requests/975Roster view improvements2023-10-19T08:37:18ZNicocoRoster view improvementsThese several commits about the roster allow to:
- Display the presence status message
- Display the idle time
- Sort by idle time
- Fold/unfold a roster group by double-clicking on it
All of this is optional and toggled off by default...These several commits about the roster allow to:
- Display the presence status message
- Display the idle time
- Sort by idle time
- Fold/unfold a roster group by double-clicking on it
All of this is optional and toggled off by default.
![gajim-roster](/uploads/2120f11c2bf8695e865014f8536156dd/gajim-roster.mp4)
I started on top of https://dev.gajim.org/gajim/gajim/-/merge_requests/970 because it uses some factoring done there.https://dev.gajim.org/gajim/gajim/-/merge_requests/973Draft: feat: use transport icons in contact avatars2023-10-02T15:36:07ZNicocoDraft: feat: use transport icons in contact avatarsIt looks OK I think?
![image](/uploads/9b3f4ebff3c534963dac2c0e3338ebbd/image.png)
This really is just a draft. The most urgent issue is that we need to hook to appropriate events so that contact avatars are updated when the gateway av...It looks OK I think?
![image](/uploads/9b3f4ebff3c534963dac2c0e3338ebbd/image.png)
This really is just a draft. The most urgent issue is that we need to hook to appropriate events so that contact avatars are updated when the gateway avatar becomes available or change. I think the lack of this explains why some contacts do not have the telegram logo (visible on the screenshot) and why in my informal tests I had a generic "red T" avatar instead of the envelope appear sometimes. Can I have some guidance about the best way to proceed here? I'm not sure where it's appropriate to trigger the avatar refresh (probably in several `gtk/` files, chat_row, chat_banner, roster…?). Besides that, I think there are other things to fix before this is ready to merge:
- [ ] Someone review my Cairo code because I'm clicking buttons but I don't really understand what I am doing
- [ ] Ensure avatars are updated when the gateway avatar becomes available
- [ ] Use the gateway avatar for groups
- [ ] Use the gateway avatar for group participants
- [ ] Harmonise behaviour with hard-coded transport icons
About that last point, I think the rule should be: if there is a hard-coded icon in gajim, we use it, but if not, we try to use the gateway's PEP avatar. Maybe it should be the other way around *but* I fear this is going to become awkward as we mix "icons that are immediately available" with "avatars that may be available later". Maybe we should ditch all hard-coded transport icons all along? I would tend to think this is a good idea except for the fact that biboumi does not have an avatar and I think it probably is the most widely-used transport for XMPP users, so it would suck a bit.https://dev.gajim.org/gajim/gajim/-/merge_requests/969feat: Show status text in roster2023-09-27T21:52:24ZAndreas Ebertusfeat: Show status text in rosterThis MR adds the ability to display the status text of a contact underneath the contact name in the roster. Similar to how it is already done in the group chat roster.
There already was a discussion on that here: gajim/gajim#11010
On...This MR adds the ability to display the status text of a contact underneath the contact name in the roster. Similar to how it is already done in the group chat roster.
There already was a discussion on that here: gajim/gajim#11010
One question was how to handle multiple status messages from different clients. In this MR I just take the one with the highest priority.https://dev.gajim.org/gajim/gajim/-/merge_requests/954new: Storage: Store occupant-id and real JID for MUC messages2023-06-06T22:03:24ZDaniel Brötzmannnew: Storage: Store occupant-id and real JID for MUC messagesPart of #11232
Can be used for #11186Part of #11232
Can be used for #11186https://dev.gajim.org/gajim/gajim/-/merge_requests/950Draft: imprv: Chat banner: Make 'Contact details and settings' button always ...2023-05-13T20:35:32ZmjkDraft: imprv: Chat banner: Make 'Contact details and settings' button always availableIt's nice to have settings accessible and cached info available during network outages or just being offline.
The dialog is already reachable using a detour via the omemo shield button, this just opens a direct path.It's nice to have settings accessible and cached info available during network outages or just being offline.
The dialog is already reachable using a detour via the omemo shield button, this just opens a direct path.https://dev.gajim.org/gajim/gajim/-/merge_requests/939imprv: GroupchatRoster: Don’t show participants if roster size is big2023-05-09T18:52:30ZPhilipp Höristphilipp@hoerist.comimprv: GroupchatRoster: Don’t show participants if roster size is bighttps://dev.gajim.org/gajim/gajim/-/merge_requests/935Change win CI to use CLANG64 env2023-04-16T15:51:04ZMichel Le BihanChange win CI to use CLANG64 envhttps://dev.gajim.org/gajim/gajim/-/merge_requests/909fix: Roster: Filter contacts by status in high-performance mode2023-02-10T20:21:08ZDaniel Brötzmannfix: Roster: Filter contacts by status in high-performance modeFixes #11330Fixes #11330https://dev.gajim.org/gajim/gajim/-/merge_requests/900cq: Remove unused local variables2023-01-06T19:18:29Zmesoniumcq: Remove unused local variablesChecked with PyCharm's analyzing tool.Checked with PyCharm's analyzing tool.https://dev.gajim.org/gajim/gajim/-/merge_requests/873feat: Add key binding to toggle workspace panel2022-11-14T09:31:03ZIzayafeat: Add key binding to toggle workspace panelThis fairly simple modification adds a key binding (^Y) to toggle display of the workspace panel, which would hopefully satisfy #11068. Also included is an update to the shortcuts window to include it. This was originally posted as a pat...This fairly simple modification adds a key binding (^Y) to toggle display of the workspace panel, which would hopefully satisfy #11068. Also included is an update to the shortcuts window to include it. This was originally posted as a patch file in the Gajim MUC around the release of 1.4, but I hadn't gotten around to submitting it until now.
I'm not overly attached to the specific keybinding, but it wasn't in use. If anyone has compelling arguments for a different binding I'm all ears.https://dev.gajim.org/gajim/gajim/-/merge_requests/867imprv: ChatStack: Sort when mouse exits2022-11-28T18:13:54Zmjkimprv: ChatStack: Sort when mouse exitsI think my suggested diff got lost in the chat. ^^'
Without this, there's an impression of application's brokenness, as the chat list can stay unsorted for a long while.I think my suggested diff got lost in the chat. ^^'
Without this, there's an impression of application's brokenness, as the chat list can stay unsorted for a long while.https://dev.gajim.org/gajim/gajim/-/merge_requests/866Draft: imprv: Disable Jingle file transfer action if chat is encrypted2022-11-24T20:52:17ZDaniel BrötzmannDraft: imprv: Disable Jingle file transfer action if chat is encryptedThis avoids accidentally sending files unencrypted when using Jingle.
Jingle Encrypted Transfer (JET) is the long term solution for this, see gajim/gajim-plugins#481This avoids accidentally sending files unencrypted when using Jingle.
Jingle Encrypted Transfer (JET) is the long term solution for this, see gajim/gajim-plugins#481https://dev.gajim.org/gajim/gajim/-/merge_requests/859Display component presence info2023-09-30T07:59:43ZNicocoDisplay component presence infoFix #10963
I am not convinced that this is the proper way to do that, but it seems to work.
Please give me pointers about what to do in case this is too "hacky".Fix #10963
I am not convinced that this is the proper way to do that, but it seems to work.
Please give me pointers about what to do in case this is too "hacky".https://dev.gajim.org/gajim/gajim/-/merge_requests/858Read state sync for MUC2022-11-04T22:58:44ZNicocoRead state sync for MUCHalf-fix: #11170
I think this is OK after a few quick tests but it seems too simple to be true, so let me know what I overlooked/misused/broke.
Tested and plays nice with Dino and Conversations.Half-fix: #11170
I think this is OK after a few quick tests but it seems too simple to be true, so let me know what I overlooked/misused/broke.
Tested and plays nice with Dino and Conversations.