gajim merge requestshttps://dev.gajim.org/gajim/gajim/-/merge_requests2023-01-20T22:27:45Zhttps://dev.gajim.org/gajim/gajim/-/merge_requests/824fix: calls: Align bitrates in DSP2023-01-20T22:27:45ZMartin Kennedyfix: calls: Align bitrates in DSPThis commit aligns bitrates between webrtc echo probe and dsp.
Before this commit, if the far-end source was sending audio to the
caller at a rate of e.g. 8000, that stream would be consumed by the
echo probe and would require that the ...This commit aligns bitrates between webrtc echo probe and dsp.
Before this commit, if the far-end source was sending audio to the
caller at a rate of e.g. 8000, that stream would be consumed by the
echo probe and would require that the DSP doing audio clean-up also
process output data at rate 8000:
> ... gst-stream-error-quark: Echo Probe has rate 8000 , while the DSP is running at rate 48000, use a caps filter to ensure those are the same. (11)
See issue #11023 [1] for more logs like the above.
To fix this, add an audioresample[2] and capsfilter[3] to the
sink (corresponding to the local speakers, for example) so that output
is the same rate as input, tacked at rate 48000.
Fixes: b5e9c8e389dc95e9ea724316723f2c0e9fba7429 ("Calls: Add DSP")
[1]: https://dev.gajim.org/gajim/gajim/-/issues/11023
[2]: https://gstreamer.freedesktop.org/documentation/audioresample/index.html?gi-language=c
[3]: https://gstreamer.freedesktop.org/documentation/coreelements/capsfilter.html?gi-language=c
Signed-off-by: Martin Kennedy <hurricos@gmail.com>