Bookmarks (Group Chat) crash on account with empty Label
Versions
- OS: Linux
- GTK+ Version: 3.22.30
- PyGObject Version: 3.26.1
- python-nbxmpp Version: 0.6.10
- Gajim Version: 1.1.3
Traceback
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/gajim/gtk/bookmarks.py", line 222, in on_ok_button_clicked
gui_menu_builder.build_bookmark_menu(acct)
File "/usr/lib/python3.6/site-packages/gajim/gui_menu_builder.py", line 837, in build_bookmark_menu
label = menu.get_item_attribute_value(1, 'label').get_string()
UnboundLocalError: local variable 'menu' referenced before assignment
Steps to reproduce the problem
- Have at least one account with empty "Label" in the account settings (probably set up with Gajim < 1.0)
- Maybe need to restart Gajim after clearing the label.
- Open Bookmarks (Group Chat)
- Click "OK"
Comment: Why is Gajim development not using mypy to find missing assignments before releasing code?