Treatment of groupchat message with both subject and body elements (#9491) · Issues · gajim / gajim

Treatment of groupchat message with both subject and body elements

Please first check if another issue has been opened for your problem

Versions

OS: Debian Linux
Gajim version: 1.1.91+d129f555
GTK version: 3.22.11
Python-nbxmpp version: 0.9.90

Steps to reproduce the problem

Receive from a MUC

<message type="groupchat">
  <subject>Did you know</subject>
  <body>Normal groupchat messages can have a subject line</body>
</message>

Expected behavior

The message is treated as a groupchat message and the <body> content is shown. If individual messages can be rendered with a subject, then do that maybe?

Actual behavior

The topic is changed. The <body> content is not shown.

Specification

XEP-0045 says

The subject is changed by sending a message of type "groupchat" to the <room@service>, where the <message/> MUST contain a <subject/> element that specifies the new subject but MUST NOT contain a <body/> element (or a <thread/> element). In accordance with the core definition of XMPP, other child elements are allowed (although the entity that receives them might ignore them).

Note: A message with a <subject/> and a <body/> or a <subject/> and a <thread/> is a legitimate message, but it SHALL NOT be interpreted as a subject change.

**Please first check if another issue has been opened for your problem**

## Versions

- OS: Debian Linux
  - Gajim version: 1.1.91+d129f5559a88
  - GTK version:  3.22.11
  - Python-nbxmpp version: 0.9.90

## Steps to reproduce the problem

1. Receive from a MUC

```xml
<message type="groupchat">
  <subject>Did you know</subject>
  <body>Normal groupchat messages can have a subject line</body>
</message>
```

## Expected behavior

The message is treated as a groupchat message and the `<body>` content is shown. If individual messages can be rendered with a subject, then do that maybe?

## Actual behavior

The topic is changed. The `<body>` content is not shown.

## Specification

[XEP-0045](https://xmpp.org/extensions/xep-0045.html#subject-mod) says
> The subject is changed by sending a message of type "groupchat" to the \<room@service\>, where the `<message/>` MUST contain a `<subject/>` element that specifies the new subject but MUST NOT contain a `<body/>` element (or a `<thread/>` element). In accordance with the core definition of XMPP, other child elements are allowed (although the entity that receives them might ignore them).
>
> Note: A message with a `<subject/>` and a `<body/>` or a `<subject/>` and a `<thread/>` is a legitimate message, but it SHALL NOT be interpreted as a subject change.

Discussion
Designs