Skip to content

GitLab

gajim
gajim
Closed
Opened by Zash@Zash

Wrong form type when responding to a voice request

Versions

  • OS: Debian 9.4
  • Gajim version: 1.0.3+6413c568
  • GTK version: 3.22.11
  • Python-nbxmpp version: 0.6.6

Steps to reproduce the problem

  1. Someone requests voice in a room where you are moderator
  2. Fill in the form and send it
  3. Observe XML console or equivalent

Expected behavior

The data form should have type="submit" when submitting.

See https://xmpp.org/extensions/xep-0045.html#voiceapprove

Actual behavior

<message to="room@rooms.example.com" id="54da56b8-4268-483f-82e2-fe52aa8d2672" type="normal">
  <x xmlns="jabber:x:data" type="form">
    <title>Voice Request</title>
    <field var="FORM_TYPE" type="hidden">
      <value>http://jabber.org/protocol/muc#request</value>
    </field>
    <field label="User ID" var="muc#jid" type="jid-single">
      <value>user@example.com/resource</value>
    </field>
    <field label="Room Nickname" var="muc#roomnick" type="text-single">
      <value>Someone</value>
    </field>
    <field label="Requested Role" var="muc#role" type="text-single">
      <value>participant</value>
    </field>
    <field label="Grant voice to this person?" var="muc#request_allow" type="boolean">
      <value>1</value>
    </field>
  </x>
</message>

Note type="form".