Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gajim
gajim
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 210
    • Issues 210
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 22
    • Merge Requests 22
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gajim
  • gajimgajim
  • Issues
  • #9124

Closed
Open
Opened May 12, 2018 by Robin Müller@coder-hugo

Click on notification doesn't refocus the chat window

Versions

  • OS: Linux
  • GTK+ Version: 3.22.30
  • PyGObject Version: 3.28.2
  • python-nbxmpp Version: 0.6.5
  • Gajim Version: 1.0.2+6cdcbf11

Steps to reproduce the problem

  1. configure notifications for incoming messages
  2. move the chat window in the background
  3. send a message from a different account to receive a notification
  4. click on the notification

Expected behavior

The chat window that corresponds to the message form the notification comes to the front.

Actual behavior

The notification disappears and the window stays in the background.

Additional information

I did some debugging and found 2 issues which cause this bug:

  • The first is that in line 2640 of the connection_handlers_events.py the value for popup_msg_type is set to chat. During the debugging i figured out that this value should be printed_chat otherwise the code, that has to find the corresponding event which contains a reference to the chat window, doesn't work.
  • The second issue looks more like a bug in GTK or Gnome. Cause the API tells that the chat window is still visible although it's in the background. It seems that invoking the method present on a window that is already visible has no effect. If I call the method hide of the window just before the method present (gui_interface.py:1771) the window comes to the front.
Edited May 12, 2018 by Robin Müller
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gajim/gajim#9124