patch to allow disabling SASL from UI
xmpppy used to fallback on sasl problem. alexey found out that this an RFC violation and it removed it. jabberpl.org suffers coz it says it does SASL but then fails. I talked to the admin there, he uses Psi [which doesn't do SASL] so he wasn't aware of that fact. He has jabberd2, s8 hopefully it's his config.
Alexey told he has never faced another server that does this, but anyways he produced a patch for disabling SASL
Index: client.py
===================================================================
RCS file: /cvsroot/xmpppy/xmpppy/xmpp/client.py,v
retrieving revision 1.37
diff -u -r1.37 client.py
--- client.py 12 May 2005 09:00:23 -0000 1.37
+++ client.py 23 May 2005 12:34:51 -0000
@@ -184,7 +184,7 @@
self.connected='tls'
return self.connected
- def auth(self,user,password,resource=''):
+ def auth(self,user,password,resource='',NonSASL=0):
""" Authenticate connnection and bind resource. If resource is not provided
random one or library name used. """
self._User,self._Password,self._Resource=user,password,resource
@@ -192,7 +192,7 @@
if self.Dispatcher.Stream._document_attrs.has_key('version') and self.Dispatcher.Stream._document_attrs['version']=='1.0':
while not self.Dispatcher.Stream.features and self.Process(): pass # If we get version 1.0 stream the features tag MUST BE presented
auth.SASL().PlugIn(self)
- if self.SASL.startsasl=='not-supported':
+ if NonSASL or self.SASL.startsasl=='not-supported':
if not resource: resource='xmpppy'
if auth.NonSASL(user,password,resource).PlugIn(self):
self.connected+='+old_auth'
I copy paste here coz I 'm not sure if the admin broke his config or jabberd2,s8 is broken in this area. anyways this patch is useful but won't make it to 0.7. we'll see what happens afterwards. If we get to include it just in case we need a gui option [right to Use TLS or in that tab anyways]