Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gajim
gajim
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 210
    • Issues 210
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 22
    • Merge Requests 22
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gajim
  • gajimgajim
  • Issues
  • #10141

Closed
Open
Opened Jun 20, 2020 by Klexx@Klexx

Exception when handling MultipleDataForms

It seems that FormGrid is not capable of handling MultipleDataForm objects.

Versions

  • OS: debian (sid)
  • Gajim version: 1.2.91+3f38952e (master)
  • GTK version: 3.24.20
  • Python-nbxmpp version: 1.0.0

Steps to reproduce the problem

  1. call an adhoc command which replies with a "MultipleDataForm"

Example MultipleDataForm

<iq type="result" to="me@foo.bar/gajim" from="x.foo.bar">
    <command xmlns="http://jabber.org/protocol/commands" node="list_foobar" status="completed">
        <x xmlns="jabber:x:data" type="result">
            <title>foobar!</title>
            <reported>
                <field var="memo" />
                <field var="value" />
                <field var="type" />
            </reported>
            <item>
                <field var="memo">
                    <value>tes</value>
                </field>
                <field var="value">
                    <value>1</value>
                </field>
                <field var="type">
                    <value>bar</value>
                </field>
            </item>
            <item>
                <field var="memo">
                    <value>tes</value>
                </field>
                <field var="value">
                    <value>1</value>
                </field>
                <field var="type">
                    <value>bar</value>
                </field>
            </item>
        </x>
    </command>
</iq>

Expected behavior

render form correctly

Actual behavior

Traceback (most recent call last):
  File "/home/test/.local/lib/python3.8/site-packages/nbxmpp/dispatcher.py", line 421, in dispatch
    func(self._client, stanza, **user_data)
  File "/home/test/.local/lib/python3.8/site-packages/nbxmpp/util.py", line 123, in func_wrapper
    cb()(result)
  File "/home/test/gajim/gajim/gtk/util.py", line 532, in func_wrapper
    return func(self, *args, **kwargs)
  File "/home/test/gajim/gajim/gtk/adhoc.py", line 220, in _received_stage
    stage_page.process_stage(stage)
  File "/home/test/gajim/gajim/gtk/adhoc.py", line 420, in process_stage
    self._show_form(stage_data.data)
  File "/home/test/gajim/gajim/gtk/adhoc.py", line 446, in _show_form
    self._dataform_widget = DataFormWidget(
  File "/home/test/gajim/gajim/gtk/dataform.py", line 61, in __init__
    self._form_grid = FormGrid(form_node, options)
  File "/home/test/gajim/gajim/gtk/dataform.py", line 129, in __init__
    self._analyse_fields(form_node, options)
  File "/home/test/gajim/gajim/gtk/dataform.py", line 151, in _analyse_fields
    for field in form_node.iter_fields():
  File "/home/test/.local/lib/python3.8/site-packages/nbxmpp/simplexml.py", line 563, in __getattr__
    raise AttributeError
AttributeError
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gajim/gajim#10141