Skip to content

GitLab

Closed
Created by Ghost User@ghostContributor

Validating URLs that contain long username:password@ parts results in '(Invalid URL)' when too long

Please first check if another issue has been opened for your problem

Versions

  • OS: Linux / OpenBSD
  • Gajim version: 1.1.3
  • GTK version: 3.24.14
  • Python-nbxmpp version: 0.6.10

Steps to reproduce the problem

  1. Select URL "http://etwas-mit-bindestrich:und-password@undvielzulangemundunverstaendlichemhostnamevielliecht.onion"
  2. Paste it into a chat window
  3. Example output: '‎C-Keen‎: http://etwas-mit-bindestrich:und-password@undvielzulangemundunverstaendlichemhostnamevielliecht.onion (Invalid URL)'

Expected behavior

The URL should not be marked as Invalid.

Actual behavior

The code in File "/usr/local/lib/python3.7/encodings/idna.py", line 73, in ToASCII checks the domain name part and also checks the username:password@ bit. That's incorrect and results in a too long token.