Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gajim
gajim
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 196
    • Issues 196
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 21
    • Merge Requests 21
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • gajim
  • gajimgajim
  • Issues
  • #10010

Closed
Open
Opened Mar 13, 2020 by Ghost User@ghostContributor

Validating URLs that contain long username:password@ parts results in '(Invalid URL)' when too long

Please first check if another issue has been opened for your problem

Versions

  • OS: Linux / OpenBSD
  • Gajim version: 1.1.3
  • GTK version: 3.24.14
  • Python-nbxmpp version: 0.6.10

Steps to reproduce the problem

  1. Select URL "http://etwas-mit-bindestrich:und-password@undvielzulangemundunverstaendlichemhostnamevielliecht.onion"
  2. Paste it into a chat window
  3. Example output: '‎C-Keen‎: http://etwas-mit-bindestrich:und-password@undvielzulangemundunverstaendlichemhostnamevielliecht.onion (Invalid URL)'

Expected behavior

The URL should not be marked as Invalid.

Actual behavior

The code in File "/usr/local/lib/python3.7/encodings/idna.py", line 73, in ToASCII checks the domain name part and also checks the username:password@ bit. That's incorrect and results in a too long token.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gajim/gajim#10010