Transport in roster not being discovered
- OS: Debian
- Gajim version: 1.1.2, 1.1.3
- GTK version: 3.24.5
- Python-nbxmpp version: 0.6.10
Steps to reproduce the problem
- Add cheogram.com to roster
- Add +firstname.lastname@example.org to roster
Both roster items should show the "cellphone" icon
Also, when opening the "add contact" window a drop-down should allow selecting "sms" as a kind of contact to add.
Both roster items show with the default icon and "add contact" window remains as though no transports were installed.
This is a regression, it definitely used to work. In fact, on one of my systems where I am running 1.1.2 but upgraded from an older version (0.16 and maybe earlier, it's a system that's been upgraded several times) the icons and "add contact" window are still working correctly -- presumably because the CAPS cache still has the right gateway data in it.
Looking at gajim/common/modules/discovery.py it appears that service discovery and testing for gateway type only happen on items that come from one's own server and no longer happen on any roster items? If so, it would seem that the fix is to allow processing service discovery for roster items to check if they are a gateway.