gajim issueshttps://dev.gajim.org/gajim/gajim/-/issues2024-03-22T20:26:09Zhttps://dev.gajim.org/gajim/gajim/-/issues/11788AttributeError: 'JID' object has no attribute 'find'2024-03-22T20:26:09ZDaniel BrötzmannAttributeError: 'JID' object has no attribute 'find'# Error Details:
- Sentry event: https://sentry.io/gajim-aec982731/gajim/issues/5090271336
- First seen:
2024-03-21T19:46:02+00:00
- Last seen: 2024-03-21T19:46:02+00:00
- Event: 1
- Users: 0# Error Details:
- Sentry event: https://sentry.io/gajim-aec982731/gajim/issues/5090271336
- First seen:
2024-03-21T19:46:02+00:00
- Last seen: 2024-03-21T19:46:02+00:00
- Event: 1
- Users: 0https://dev.gajim.org/gajim/gajim/-/issues/11747MUC subject should not update if there is a <thread/>2024-02-12T20:06:03ZsingpolymaMUC subject should not update if there is a <thread/>Thus saith the xep:
```
Note: A message with a <subject/> and a <body/> or a <subject/> and a <thread/> is a legitimate message, but it SHALL NOT be interpreted as a subject change.
```Thus saith the xep:
```
Note: A message with a <subject/> and a <body/> or a <subject/> and a <thread/> is a legitimate message, but it SHALL NOT be interpreted as a subject change.
```https://dev.gajim.org/gajim/gajim/-/issues/11709Creation of multiple unnamed group chats bug2023-12-03T12:31:50Zdiode24Creation of multiple unnamed group chats bugAfter creating more than one group chats without giving them a name, gajim will display erroneous information about the second created group chat and all after that.
## Steps to reproduce bug
1. create a new account on nixnet.services
2...After creating more than one group chats without giving them a name, gajim will display erroneous information about the second created group chat and all after that.
## Steps to reproduce bug
1. create a new account on nixnet.services
2. create a new group chat with the nixnet.services account, do not change any settings for this group chat, do not name it, use all defaults, press create button
3. repeat step 2 to create another group chat with the same nixnet.services account
4. restart gajim
5. jids and names for the second created group chat will be wrong in some spots in the 'Share Group Chat' button and 'Group Chat Details'
6. creating more group chats will have the same problem
I haven't experienced this when testing on prosody and it doesn't happen on all ejabberd servers. Conversations.im does not produce this bug behavior in my testing.
Versions at the time of my testing:
- gajim-nightly
- nixnet.services: ejabberd 23.4.0
- conversations.im: ejabberd 19.05.13-conversations.imhttps://dev.gajim.org/gajim/gajim/-/issues/11682Error when trying to create group chat, disco_info is not None2023-11-11T16:40:07ZDaniel BrötzmannError when trying to create group chat, disco_info is not None```
Traceback (most recent call last):
File "/home/x/.local/lib/python3.11/site-packages/nbxmpp/dispatcher.py", line 475, in dispatch
handler['func'](self._client, stanza, properties)
File "/home/x/DEV/Gajim/gajim/gajim/common/mo...```
Traceback (most recent call last):
File "/home/x/.local/lib/python3.11/site-packages/nbxmpp/dispatcher.py", line 475, in dispatch
handler['func'](self._client, stanza, properties)
File "/home/x/DEV/Gajim/gajim/gajim/common/modules/vcard_avatars.py", line 121, in _presence_received
self._muc_update_received(properties)
File "/home/x/DEV/Gajim/gajim/gajim/common/modules/vcard_avatars.py", line 189, in _muc_update_received
allow_query = contact.room.get_config_value('allow_query_users')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/x/DEV/Gajim/gajim/gajim/common/modules/contacts.py", line 775, in get_config_value
assert disco_info is not None
^^^^^^^^^^^^^^^^^^^^^^
AssertionError
```https://dev.gajim.org/gajim/gajim/-/issues/11670"A new room was created" is always the latest message when opening a MUC.2023-11-18T10:32:12ZNicoco"A new room was created" is always the latest message when opening a MUC.## Versions
- Gajim version: 1.8.2
## Steps to reproduce the problem
1. Create a public MUC
1. Send a few messages in it
1. Switch to another chat tab
1. Switch back to the newly created MUC
## Expected behavior
The "info ...## Versions
- Gajim version: 1.8.2
## Steps to reproduce the problem
1. Create a public MUC
1. Send a few messages in it
1. Switch to another chat tab
1. Switch back to the newly created MUC
## Expected behavior
The "info row" showing "A new room was created" (not 100% sure about the original text, in French: "Un nouveau salon a été créé"), should be the first row in this MUC history.
## Actual behavior
The row keeps on appearing as the latest row in this MUC, when opened.
![Screenshot_20231102_161056](/uploads/f491f03326dc4cf9d07336deb5df1e8c/Screenshot_20231102_161056.png)
switch to another tab, come back…
![Screenshot_20231102_161108](/uploads/9c11ee2868194acfe73fab34b6b45428/Screenshot_20231102_161108.png)
This is particularly misleading as there is a (wrong) timestamp associated with this info row.1.8.3https://dev.gajim.org/gajim/gajim/-/issues/11666MUC: AssertionError whild calling _load_roster()2023-10-31T21:41:13ZDaniel BrötzmannMUC: AssertionError whild calling _load_roster()# Error Details:
- Sentry event: https://sentry.io/gajim-aec982731/gajim/issues/4585602447
- First seen:
2023-10-30T06:15:17+00:00
- Last seen: 2023-10-30T06:15:17+00:00
- Event: 1
- Users: 0# Error Details:
- Sentry event: https://sentry.io/gajim-aec982731/gajim/issues/4585602447
- First seen:
2023-10-30T06:15:17+00:00
- Last seen: 2023-10-30T06:15:17+00:00
- Event: 1
- Users: 01.8.3https://dev.gajim.org/gajim/gajim/-/issues/11613Assertion error when being mentioned in a MUC2023-08-31T07:00:12ZAndréAssertion error when being mentioned in a MUC## Versions
- OS: Arch Linux
- Gajim version: 1.8.1
- GTK version: 3.24.38
- Python-nbxmpp version: 4.3.2
## Steps to reproduce the problem
1. Be mentioned in a MUC
## Expected behavior
## Actual behavior
```
(E) gajim.c....## Versions
- OS: Arch Linux
- Gajim version: 1.8.1
- GTK version: 3.24.38
- Python-nbxmpp version: 4.3.2
## Steps to reproduce the problem
1. Be mentioned in a MUC
## Expected behavior
## Actual behavior
```
(E) gajim.c.ged Error while running an event handler: <bound method NotificationBackend._on_notification of <gajim.gtk.notification.Linux object at 0x7f118b6e7610>>
Traceback (most recent call last):
File "/usr/lib/python3.11/site-packages/gajim/common/ged.py", line 100, in raise_event
if handler(event_obj):
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/gajim/gtk/notification.py", line 109, in _on_notification
self._send(event)
File "/usr/lib/python3.11/site-packages/gajim/gtk/notification.py", line 345, in _send
icon = self._make_icon(event)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/gajim/gtk/notification.py", line 399, in _make_icon
return _get_avatar_for_notification(event.account, event.jid)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/gajim/gtk/notification.py", line 427, in _get_avatar_for_notification
assert isinstance(contact, BareContact | GroupchatParticipant)
AssertionError
```1.8.2https://dev.gajim.org/gajim/gajim/-/issues/11557Silent failure to join muc.example.com when no MUC service discovered2023-06-08T19:03:21ZMattJSilent failure to join muc.example.com when no MUC service discovered## Versions
- OS: Debian
- Gajim version: 1.8.0 (also tested 1.5.4)
Using Flatpak.
## Steps to reproduce the problem
1. Connect to an XMPP server with no discoverable MUC service
2. Next to the search box, press '+' and 'Crea...## Versions
- OS: Debian
- Gajim version: 1.8.0 (also tested 1.5.4)
Using Flatpak.
## Steps to reproduce the problem
1. Connect to an XMPP server with no discoverable MUC service
2. Next to the search box, press '+' and 'Create group chat...'
3. Enter a name and click 'Create'
## Expected behavior
I should receive some feedback that I'm unable to create a group chat.
## Actual behavior
In the XML console I observe stanzas sent to '[random id]@muc.example.com' which is a server that does not exist. My server fails to connect and returns an error to the stanza, but Gajim still does not display any failure.
It seems to me that there may be several sub-issues here of varying importance:
- There is no indication to the user that their server doesn't support group chat creation
- Defaulting to muc.example.com is always wrong, regardless of anything else
- An error response during room creation gives no feedback to the user (the creation dialog just stays, with 'Create' button disabled).1.8.1https://dev.gajim.org/gajim/gajim/-/issues/11554MUC on re-join: AttributeError 'NoneType' object has no attribute 'send'2023-06-06T18:22:04ZDaniel BrötzmannMUC on re-join: AttributeError 'NoneType' object has no attribute 'send'# Error Details:
- Sentry event: https://dev.gajim.org/gajim/gajim/-/error_tracking/36/details
- First seen:
2023-06-06T04:03:56+00:00
- Last seen: 2023-06-06T04:03:57+00:00
- Event: 1
- Users: 0# Error Details:
- Sentry event: https://dev.gajim.org/gajim/gajim/-/error_tracking/36/details
- First seen:
2023-06-06T04:03:56+00:00
- Last seen: 2023-06-06T04:03:57+00:00
- Event: 1
- Users: 0https://dev.gajim.org/gajim/gajim/-/issues/11393History is missing if one is joined a groupchat with 2 accounts2023-12-26T13:28:03ZPhilipp Höristphilipp@hoerist.comHistory is missing if one is joined a groupchat with 2 accountsWhen someone is joined with two accounts the same groupchat in Gajim, history is not downloaded for both accounts.
The problem seems to be that the database table who stores the last mam-id is not account specific.When someone is joined with two accounts the same groupchat in Gajim, history is not downloaded for both accounts.
The problem seems to be that the database table who stores the last mam-id is not account specific.https://dev.gajim.org/gajim/gajim/-/issues/11334Participant's "/me" in MUCs display user's own nick instead of participant ni...2022-12-17T18:59:18ZNicocoParticipant's "/me" in MUCs display user's own nick instead of participant nick in notification**Please first check if another issue has been opened for your problem**
## Versions
- OS: Debian bullseye
- Gajim version: 1.5.4 flatpak
## Steps to reproduce the problem
1. Be in a MUC with a nickname, eg, "Nicoco"
1. Let t...**Please first check if another issue has been opened for your problem**
## Versions
- OS: Debian bullseye
- Gajim version: 1.5.4 flatpak
## Steps to reproduce the problem
1. Be in a MUC with a nickname, eg, "Nicoco"
1. Let this chat be out of focus
1. Receive a "/me is very clever" from your friend "Bob"
## Expected behavior
The notification should show "New message from Bob.\n * Bob is very clever."
## Actual behavior
The notification shows "New message from Bob.\n * Nicoco is very clever."
This does not seem to happen for 1:1, only for MUCs.1.6.0https://dev.gajim.org/gajim/gajim/-/issues/11250error when editing MUC subject2022-10-28T20:03:15Zdiode24error when editing MUC subject- GTK Version: 3.24.33
- GLib Version: 2.71.3
- Pango Version: 1.50.6
- PyGObject Version: 3.42.1
- cairo Version: 1.16.0
- pycairo Version: 1.20.1
- python-nbxmpp Version: 3.2.4
- gajim version: gajim-default-nightly 20221026-1
- OS: ub...- GTK Version: 3.24.33
- GLib Version: 2.71.3
- Pango Version: 1.50.6
- PyGObject Version: 3.42.1
- cairo Version: 1.16.0
- pycairo Version: 1.20.1
- python-nbxmpp Version: 3.2.4
- gajim version: gajim-default-nightly 20221026-1
- OS: ubuntu 22.04
```
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/gajim/gtk/groupchat_manage.py", line 108, in _on_subject_text_changed
assert self._contact.subject is not None
AssertionError
```
## Steps to reproduce problem
1. be in chat view of muc where you have owner permissions
2. go to burger menu > Details > Manage
3. enter some text into the box below Subject
## Expected behavior
Enter text, then press 'Change Subject' button and subject updates.
## Actual behavior
As soon as I type text into the Subject box, the error occurs and the Change Subject button does not work. The traceback appears in the debug log.https://dev.gajim.org/gajim/gajim/-/issues/11247KeyError 'jabber.calyxinstitute.org' when trying to close group chat2022-10-28T20:03:15ZDaniel BrötzmannKeyError 'jabber.calyxinstitute.org' when trying to close group chat# Error Details:
- Sentry event: https://dev.gajim.org/gajim/gajim/-/error_tracking/25/details
- First seen:
2022-10-20T06:06:21+00:00
- Last seen: 2022-10-20T06:06:20+00:00
- Event: 1
- Users: 0# Error Details:
- Sentry event: https://dev.gajim.org/gajim/gajim/-/error_tracking/25/details
- First seen:
2022-10-20T06:06:21+00:00
- Last seen: 2022-10-20T06:06:20+00:00
- Event: 1
- Users: 01.5.3https://dev.gajim.org/gajim/gajim/-/issues/11231gajim crashed when trying to access details of a disconnected muc2023-06-02T14:35:31ZPirate Praveen Arimbrathodiyilgajim crashed when trying to access details of a disconnected muc## Versions:
- OS: Debian GNU/Linux bookworm/sid n/a (bookworm)
- GTK Version: 3.24.34
- PyGObject Version: 3.42.2
- GLib Version : 2.74.0
- python-nbxmpp Version: 3.2.4
- Gajim Version: 1.5.2
## Traceback
```
Traceback (most recent cal...## Versions:
- OS: Debian GNU/Linux bookworm/sid n/a (bookworm)
- GTK Version: 3.24.34
- PyGObject Version: 3.42.2
- GLib Version : 2.74.0
- python-nbxmpp Version: 3.2.4
- Gajim Version: 1.5.2
## Traceback
```
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/gajim/gtk/chat_stack.py", line 577, in _on_action
open_window('GroupchatDetails', contact=contact)
File "/usr/lib/python3/dist-packages/gajim/gtk/util.py", line 700, in open_window
window = window_cls(**kwargs)
File "/usr/lib/python3/dist-packages/gajim/gtk/groupchat_details.py", line 74, in __init__
self._add_groupchat_manage()
File "/usr/lib/python3/dist-packages/gajim/gtk/groupchat_details.py", line 136, in _add_groupchat_manage
self._groupchat_manage = GroupchatManage(self.account,
File "/usr/lib/python3/dist-packages/gajim/gtk/groupchat_manage.py", line 64, in __init__
self._prepare_manage()
File "/usr/lib/python3/dist-packages/gajim/gtk/groupchat_manage.py", line 134, in _prepare_manage
assert self_contact
AssertionError
```
## Steps to reproduce the problem
In an MUC with a status "You left this group chat Join" status trying access details gave a crash. This group was not left manually but probably due to bad connection this was in this state. This could be another bug, where mucs with disconnected state should be highlighted and offered to rejoin.1.8.1https://dev.gajim.org/gajim/gajim/-/issues/11191MUC: Handle configuration change messages correctly2022-10-05T13:40:44ZPhilipp Höristphilipp@hoerist.comMUC: Handle configuration change messages correctlyhttps://xmpp.org/extensions/xep-0045.html#roomconfig-notifyhttps://xmpp.org/extensions/xep-0045.html#roomconfig-notify1.5.2https://dev.gajim.org/gajim/gajim/-/issues/11175Discovery window allows to join MUC component2022-09-28T19:15:15ZAlexander YakovlevDiscovery window allows to join MUC component## Versions:
- OS: Arch Linux rolling (n/a)
- GTK Version: 3.24.34
- PyGObject Version: 3.42.2
- GLib Version : 2.74.0
- python-nbxmpp Version: 3.2.1
- Gajim Version: 1.4.7
## How to reproduce
Open the Discover dialog -> quicksy.im -> ...## Versions:
- OS: Arch Linux rolling (n/a)
- GTK Version: 3.24.34
- PyGObject Version: 3.42.2
- GLib Version : 2.74.0
- python-nbxmpp Version: 3.2.1
- Gajim Version: 1.4.7
## How to reproduce
Open the Discover dialog -> quicksy.im -> chatrooms -> join
Presumably the conferences are closed for other servers so it's fine to fail but Gajim should somehow catch this failure.
On trying this again the main window says (message not localised): "No module is handling this query" and offers to try again. This is also probably misleading for the user.
## Traceback
```
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/gajim/gtk/discovery.py", line 1361, in _on_join_button_clicked
app.interface.show_add_join_groupchat(self.account, service)
File "/usr/lib/python3.10/site-packages/gajim/gui_interface.py", line 404, in show_add_join_groupchat
app.window.add_group_chat(account, JID.from_string(jid), select=True)
File "/usr/lib/python3.10/site-packages/gajim/gtk/main.py", line 601, in add_group_chat
self._chat_page.add_chat_for_workspace(workspace_id,
File "/usr/lib/python3.10/site-packages/gajim/gtk/chat_page.py", line 233, in add_chat_for_workspace
self._control_stack.add_group_chat(account, jid)
File "/usr/lib/python3.10/site-packages/gajim/gtk/control_stack.py", line 90, in add_group_chat
control = GroupchatControl(account, jid)
File "/usr/lib/python3.10/site-packages/gajim/gtk/controls/groupchat.py", line 165, in __init__
self._update_avatar()
File "/usr/lib/python3.10/site-packages/gajim/gtk/controls/groupchat.py", line 557, in _update_avatar
surface = self.contact.get_avatar(
File "/usr/lib/python3.10/site-packages/gajim/common/modules/contacts.py", line 600, in get_avatar
return app.app.avatar_storage.get_muc_surface(
File "/usr/lib/python3.10/site-packages/gajim/gtk/avatar.py", line 437, in get_muc_surface
letter = self._generate_letter(name)
File "/usr/lib/python3.10/site-packages/gajim/gtk/avatar.py", line 569, in _generate_letter
for letter in name:
TypeError: 'NoneType' object is not iterable
```1.5.2https://dev.gajim.org/gajim/gajim/-/issues/11161No sound notifications in group chats2022-09-25T21:01:03ZVitoNo sound notifications in group chats**Please first check if another issue has been opened for your problem**
## Versions
- OS: Linux, Windows
- Gajim version: *1.5.1*
- GTK version: *3.24.34*
- Python-nbxmpp version: *3.2.2*
## Steps to reproduce the problem
1....**Please first check if another issue has been opened for your problem**
## Versions
- OS: Linux, Windows
- Gajim version: *1.5.1*
- GTK version: *3.24.34*
- Python-nbxmpp version: *3.2.2*
## Steps to reproduce the problem
1. Check if your sound settings for MUC are enabled.
Press play button to test if sound works ok.
1. Connect to a group chat.
1. Enable notifications for group chat.
1. Receive message in group chat without mention.
1. Receive message in group chat with mention.
## Expected behavior
Messages and mentions works as in private chat.
## Actual behavior
Messages and mentions in MUC don't produce any sound effect.1.5.2https://dev.gajim.org/gajim/gajim/-/issues/11096Joining group chat stuck at "Joining...", but can receive messages2022-10-26T10:30:45ZSebastianJoining group chat stuck at "Joining...", but can receive messages## Versions
- OS: openSUSE Tumbleweed 20220814
- Gajim version: 1.4.7
- GTK version: 2.24.34
- Python-nbxmpp version: 3.1.1
## Steps to reproduce the problem
1. Join an existing group chat
2. Tab opens, showing messages in...## Versions
- OS: openSUSE Tumbleweed 20220814
- Gajim version: 1.4.7
- GTK version: 2.24.34
- Python-nbxmpp version: 3.1.1
## Steps to reproduce the problem
1. Join an existing group chat
2. Tab opens, showing messages in the chat
## Expected behavior
1. Seeing members of the chat
2. and being able to send messages
## Actual behavior
1. Can't see members and
2. can't send messages.
3. "Joining... Abort" is showing indefinitely ![image](/uploads/63619fcdd6ff4cf583d2a25cf548317f/image.png)
I can send message in Pidgin, and see them in Gajim. Starting `gajim -vvv` also shows the incoming stanzas.
Leaving the chat and joining it again, can result in being unable to start the join again, showing
```
08/17/2022 13:57:34 (W) gajim.c.m.muc (chat.example.com) Can’t join MUC chat@conference.example.com, state: JOINING
```
and "You left this group chat. Join" while the "join" button triggers above message in the terminal. Restarting Gajim resolves this "joining" lock, but won't let me write message either.https://dev.gajim.org/gajim/gajim/-/issues/11054Error when opening a XMPP link: TypeError: 'Mock' object is not iterable2022-09-30T12:35:05ZsbaduxError when opening a XMPP link: TypeError: 'Mock' object is not iterable## Versions:
- OS: Linux 5.4.0-122-generic
- GTK Version: 3.24.34
- PyGObject Version: 3.42.1
- GLib Version : 2.72.3
- python-nbxmpp Version: 3.1.0
- Gajim Version: 1.4.6
## Traceback
```
Traceback (most recent call last):
File "/app...## Versions:
- OS: Linux 5.4.0-122-generic
- GTK Version: 3.24.34
- PyGObject Version: 3.42.1
- GLib Version : 2.72.3
- python-nbxmpp Version: 3.1.0
- Gajim Version: 1.4.6
## Traceback
```
Traceback (most recent call last):
File "/app/lib/python3.9/site-packages/gajim/gtk/application.py", line 822, in _on_groupchat_join_action
open_window('GroupchatJoin', account=account, jid=jid)
File "/app/lib/python3.9/site-packages/gajim/gtk/util.py", line 679, in open_window
window = window_cls(**kwargs)
File "/app/lib/python3.9/site-packages/gajim/gtk/groupchat_join.py", line 100, in __init__
client.get_module('Discovery').disco_muc(
File "/app/lib/python3.9/site-packages/gajim/common/modules/util.py", line 115, in func_wrapper
task_.start()
File "/app/lib/python3.9/site-packages/nbxmpp/task.py", line 182, in start
self._next_step(self)
File "/app/lib/python3.9/site-packages/nbxmpp/task.py", line 229, in _next_step
self._set_finished()
File "/app/lib/python3.9/site-packages/nbxmpp/task.py", line 233, in _set_finished
self._invoke_callbacks()
File "/app/lib/python3.9/site-packages/nbxmpp/task.py", line 255, in _invoke_callbacks
callback(self)
File "/app/lib/python3.9/site-packages/gajim/gtk/util.py", line 377, in func_wrapper
return func(self, *args, **kwargs)
File "/app/lib/python3.9/site-packages/gajim/gtk/groupchat_join.py", line 124, in _disco_info_received
self._muc_info_box.set_from_disco_info(result.info)
File "/app/lib/python3.9/site-packages/gajim/gtk/groupchat_info.py", line 173, in set_from_disco_info
surface = contact.get_avatar(
File "/app/lib/python3.9/site-packages/gajim/common/modules/contacts.py", line 775, in get_avatar
return app.app.avatar_storage.get_surface(
File "/app/lib/python3.9/site-packages/gajim/gtk/avatar.py", line 396, in get_surface
letter = self._generate_letter(name)
File "/app/lib/python3.9/site-packages/gajim/gtk/avatar.py", line 569, in _generate_letter
for letter in name:
TypeError: 'Mock' object is not iterable
```
## Steps to reproduce the problem
I were in this page https://conversations.im/#development
I clicked in the link in the "Questions?" box (xmpp:conversations@conference.siacs.eu?join) and Firefox asked me to open the link with gajim. I confirmed and Gajim crashedhttps://dev.gajim.org/gajim/gajim/-/issues/11040Crash when opening group chat info2022-07-24T15:16:55ZFrederic TeranovCrash when opening group chat info## Versions:
- OS: Windows 10
- GTK Version: 3.24.34
- PyGObject Version: 3.42.1
- GLib Version : 2.72.2
- python-nbxmpp Version: 3.1.0
- Gajim Version: 1.4.6
## Traceback
```
Traceback (most recent call last):
File "C:/msys64/home/ap...## Versions:
- OS: Windows 10
- GTK Version: 3.24.34
- PyGObject Version: 3.42.1
- GLib Version : 2.72.2
- python-nbxmpp Version: 3.1.0
- Gajim Version: 1.4.6
## Traceback
```
Traceback (most recent call last):
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.10/site-packages/gajim/gtk/controls/groupchat.py", line 380, in _on_details
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.10/site-packages/gajim/gtk/util.py", line 679, in open_window
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.10/site-packages/gajim/gtk/groupchat_details.py", line 74, in __init__
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.10/site-packages/gajim/gtk/groupchat_details.py", line 145, in _add_groupchat_info
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.10/site-packages/gajim/gtk/groupchat_info.py", line 195, in set_from_disco_info
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.10/site-packages/gajim/gtk/groupchat_info.py", line 147, in set_subject
AttributeError: 'str' object has no attribute 'author'
```
## Steps to reproduce the problem
In any group chat, click the menu button -> details. The above error message appears.
Any further attempt result in a blank window opening.
This seems to be caused by the muc_subject parameter passed to set_subject in groupchat_info.py being a string instead of the expected object. I'm not sure if this is due to a bug in gajim or to the server misbehaving (it's an Openfire 4.5.1).
I attached a patch that fixes the crash, setting only the subject text to muc_subject when it's a string. It shouldn't affect functionality when muc_subject is an object.
[0001-Fix-group-chat-info-window-crashing-when-subject-is-.patch](/uploads/621888c0bb1dcaf2377c28a1988d2504/0001-Fix-group-chat-info-window-crashing-when-subject-is-.patch)
(no merge request since apparently I don't have the rights to fork the project)1.4.7