SendFileDialog: Typing

gajim/gtk/file_transfer_send.py

@@ -17,16 +17,23 @@
 # You should have received a copy of the GNU General Public License
 # along with Gajim. If not, see <http://www.gnu.org/licenses/>.
 
+from __future__ import annotations
+
+from typing import Callable
+from typing import cast
+
 from pathlib import Path
 
 from gi.repository import Gdk
 from gi.repository import Gtk
 from gi.repository import Pango
 
-from nbxmpp import Namespace
+from nbxmpp.namespaces import Namespace
+from nbxmpp.protocol import JID
 
 from gajim.common import app
 from gajim.common.i18n import _
+from gajim.common.modules.contacts import BareContact
 
 from .filechoosers import FileChooserDialog
 from .resource_selector import ResourceSelector
@@ -34,7 +41,11 @@
 
 
 class SendFileDialog(Gtk.ApplicationWindow):
-    def __init__(self, contact, send_callback, transient_for):
+    def __init__(self,
+                 contact: BareContact,
+                 send_callback: Callable[..., bool],
+                 transient_for: Gtk.Window
+                 ) -> None:
         Gtk.ApplicationWindow.__init__(self)
         self.set_application(app.app)
         self.set_show_menubar(False)
@@ -61,24 +72,28 @@ def __init__(self, contact, send_callback, transient_for):
             constraints=[Namespace.JINGLE_FILE_TRANSFER_5])
         self._resource_selector.connect(
             'selection-changed', self._on_resource_selection)
-        self._ui.resource_box.pack_start(self._resource_selector, 1, 0, 0)
+        self._ui.resource_box.pack_start(
+            self._resource_selector, True, False, 0)
 
-        self.connect('key-press-event', self._key_press_event)
+        self.connect('key-press-event', self._on_key_press)
         self._ui.connect_signals(self)
         self.show_all()
 
-    def _on_files_changed(self, _listbox, _row):
+    def _on_files_changed(self, _listbox: Gtk.ListBox, _row: FileRow) -> None:
         sensitive = bool(len(self._ui.listbox.get_children()) > 0)
         self._ui.files_send.set_sensitive(sensitive)
 
-    def _on_resource_selection(self, _selector, state):
+    def _on_resource_selection(self,
+                               _selector: ResourceSelector,
+                               state: bool
+                               ) -> None:
         self._ui.resource_send.set_sensitive(state)
 
-    def _on_send_to_resource(self, _button):
+    def _on_send_to_resource(self, _button: Gtk.Button) -> None:
         resource_jid = self._resource_selector.get_jid()
         self._send_files(resource_jid)
 
-    def _on_send_clicked(self, _button):
+    def _on_send_clicked(self, _button: Gtk.Button) -> None:
         count = len(self._contact.get_resources())
         if count == 0 or count > 1:
             self._ui.send_stack.set_visible_child_name('resource_selection')
@@ -87,48 +102,50 @@ def _on_send_clicked(self, _button):
         resource_jid = self._contact.get_resources()[0].jid
         self._send_files(resource_jid)
 
-    def _send_files(self, resource_jid):
-        for file in self._ui.listbox.get_children():
+    def _send_files(self, resource_jid: JID) -> None:
+        files = cast(list[FileRow], self._ui.listbox.get_children())
+        for file in files:
             self._send_callback(
-                resource_jid, str(file.path), self._get_description())
+                resource_jid, str(file.file_path), self._get_description())
         self.destroy()
 
-    def _select_files(self, _button):
+    def _select_files(self, _button: Gtk.Button) -> None:
         FileChooserDialog(self._set_files,
                           select_multiple=True,
                           transient_for=self,
                           path=app.settings.get('last_send_dir'))
 
-    def _remove_files(self, _button):
+    def _remove_files(self, _button: Gtk.Button) -> None:
         selected = self._ui.listbox.get_selected_rows()
         for item in selected:
             self._ui.listbox.remove(item)
 
-    def _set_files(self, file_names):
+    def _set_files(self, file_names: str) -> None:
+        last_dir = ''
         for file in file_names:
             row = FileRow(file)
-            if row.path.is_dir():
+            if row.file_path.is_dir():
                 continue
-            last_dir = row.path.parent
+            last_dir = row.file_path.parent
             self._ui.listbox.add(row)
         self._ui.listbox.show_all()
         app.settings.set('last_send_dir', str(last_dir))
 
-    def _get_description(self):
+    def _get_description(self) -> str:
         buffer_ = self._ui.description.get_buffer()
         start, end = buffer_.get_bounds()
         return buffer_.get_text(start, end, False)
 
-    def _key_press_event(self, _widget, event):
+    def _on_key_press(self, _widget: Gtk.Widget, event: Gdk.EventKey) -> None:
         if event.keyval == Gdk.KEY_Escape:
             self.destroy()
 
 
 class FileRow(Gtk.ListBoxRow):
-    def __init__(self, path):
+    def __init__(self, path: str) -> None:
         Gtk.ListBoxRow.__init__(self)
-        self.path = Path(path)
-        label = Gtk.Label(label=self.path.name)
+        self.file_path: Path = Path(path)
+        label = Gtk.Label(label=self.file_path.name)
         label.set_ellipsize(Pango.EllipsizeMode.END)
         label.set_xalign(0)
         self.add(label)