gajim-plugins issueshttps://dev.gajim.org/gajim/gajim-plugins/-/issues2021-12-06T08:43:27Zhttps://dev.gajim.org/gajim/gajim-plugins/-/issues/317[preview] Implement click-to-play for gif previews2021-12-06T08:43:27ZDaniel Brötzmann[preview] Implement click-to-play for gif previewsRight now, once a preview is generated for a .gif file, it plays in a loop.
A click-to-play feature would add the ability to start/stop the playback, thus adding some convenience.Right now, once a preview is generated for a .gif file, it plays in a loop.
A click-to-play feature would add the ability to start/stop the playback, thus adding some convenience.https://dev.gajim.org/gajim/gajim-plugins/-/issues/341[preview] Voice message recording feature2021-12-06T08:40:26Znico[preview] Voice message recording feature~~Based on the URLImagePreview Plugin there should be a plugin giving users the ability to listen to voice recordings directly in the chat window.
It is really strange to view common attachments directly in the chat window, but listening...~~Based on the URLImagePreview Plugin there should be a plugin giving users the ability to listen to voice recordings directly in the chat window.
It is really strange to view common attachments directly in the chat window, but listening to a recording externally opens an additional player.~~
I think as Conversations / PixArt and so on do support Voice recording/ listening directly Gajim should too.https://dev.gajim.org/gajim/gajim-plugins/-/issues/343[preview] Make download folder customizable2021-12-06T08:40:20ZDaniel Brötzmann[preview] Make download folder customizablePlease make it possible to change the files/pictures folder from `.\AppData\Roaming\Gajim\downloads` to a custom directory chosen by the user.
*Split from gajim/gajim#9325*Please make it possible to change the files/pictures folder from `.\AppData\Roaming\Gajim\downloads` to a custom directory chosen by the user.
*Split from gajim/gajim#9325*https://dev.gajim.org/gajim/gajim-plugins/-/issues/400[url_image_preview] Support for XHTML-IM2021-12-06T08:40:16ZGhost User[url_image_preview] Support for XHTML-IMWhenever I get a new image URL, I see the image completely unscaled at 100% zoom in the chat window.
![Screenshot_2019-03-12_00-41-43](/uploads/b1e9d94ce3194587f77af3563b094cbb/Screenshot_2019-03-12_00-41-43.png)
But when closing the c...Whenever I get a new image URL, I see the image completely unscaled at 100% zoom in the chat window.
![Screenshot_2019-03-12_00-41-43](/uploads/b1e9d94ce3194587f77af3563b094cbb/Screenshot_2019-03-12_00-41-43.png)
But when closing the chat and reopening it, suddenly, the images are properly scaled.
![Screenshot_2019-03-12_00-44-29](/uploads/1fb6ec857b78372e4c2de2195d048901/Screenshot_2019-03-12_00-44-29.png)
This is with Gajim 1.1.1, url_image_preview 2.3.23 and Ubuntu 18.10 but it's also happening with Gajim under Windows 7 and Windows 10.https://dev.gajim.org/gajim/gajim-plugins/-/issues/437[url_image_preview] Images will not display inline with text2021-12-06T08:39:50Za11fruitless[url_image_preview] Images will not display inline with textVersion 2.3.23
Links to images in a message will not display inline if the message also includes text.
For example, if the message body only has a link everything works correctly.
"https://api.weather.gov/icons/land/dark/skc"
Howeve...Version 2.3.23
Links to images in a message will not display inline if the message also includes text.
For example, if the message body only has a link everything works correctly.
"https://api.weather.gov/icons/land/dark/skc"
However, if the message body also includes text, the image no longer displays inline.
"text https://api.weather.gov/icons/land/dark/skc"https://dev.gajim.org/gajim/gajim-plugins/-/issues/544[preview] Add calendar Event (.ics) / VCard (.vcf) preview2021-12-06T08:38:30ZDaniel Brötzmann[preview] Add calendar Event (.ics) / VCard (.vcf) preview## Description of the new feature
Parse received Event / VCard (.ics / .vcf) files and and display basic infos from the file:
* Event: DTSTART, SUMMARY, LOCATION
* VCard: FN, TEL## Description of the new feature
Parse received Event / VCard (.ics / .vcf) files and and display basic infos from the file:
* Event: DTSTART, SUMMARY, LOCATION
* VCard: FN, TELhttps://dev.gajim.org/gajim/gajim-plugins/-/issues/554[preview] Store downloaded files per JID2021-12-06T08:38:25ZDaniel Brötzmann[preview] Store downloaded files per JIDThis concerns both URL Image Preview and OMEMO, downloading files into `configpaths.get('MY_DATA')) / 'downloads'`.
I’m proposing to store downloaded files into separate (per JID) folders.
One potential use case for this would be an in...This concerns both URL Image Preview and OMEMO, downloading files into `configpaths.get('MY_DATA')) / 'downloads'`.
I’m proposing to store downloaded files into separate (per JID) folders.
One potential use case for this would be an integrated overview of files/pictures within Gajim per contact, without the need for an additional index tracking individual file-to-contact relationships. This could be implemented wthin a page of the corresponding ChatControl for example.https://dev.gajim.org/gajim/gajim-plugins/-/issues/559[preview] Use the Open Graph Protocol (OGP) to generate website previews2021-12-06T08:37:59Zpg mr[preview] Use the Open Graph Protocol (OGP) to generate website previews## Description of the new feature
The Open Graph protocol could be used to generate a short website preview. An example from Discord can be seen below:
![Screenshot_20210508_235713](/uploads/cfe987fefc2ce6f5f5973e0bfcc9376d/Screenshot_...## Description of the new feature
The Open Graph protocol could be used to generate a short website preview. An example from Discord can be seen below:
![Screenshot_20210508_235713](/uploads/cfe987fefc2ce6f5f5973e0bfcc9376d/Screenshot_20210508_235713.png)https://dev.gajim.org/gajim/gajim-plugins/-/issues/561[preview] OSError: image file is truncated (5 bytes not processed) when proce...2021-12-06T08:37:55ZSimona Eichert[preview] OSError: image file is truncated (5 bytes not processed) when processing GIF file## Versions
- OS: Windows 7
- GTK Version: 3.24.29
- PyGObject Version: 3.40.1
- GLib Version : 2.68.1
- python-nbxmpp Version: 3.0.0-dev1
- Gajim Version: 1.4.0-dev1
## Traceback
```
Traceback (most recent call last):
File "C:/msys64...## Versions
- OS: Windows 7
- GTK Version: 3.24.29
- PyGObject Version: 3.40.1
- GLib Version : 2.68.1
- python-nbxmpp Version: 3.0.0-dev1
- Gajim Version: 1.4.0-dev1
## Traceback
```
Traceback (most recent call last):
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.8/site-packages/gajim/common/helpers.py", line 1347, in _on_load_finished
File "C:\Users\Simona\Gajim-Portable-Master-64bit-2021-05-14\UserData\Plugins\url_image_preview\url_image_preview.py", line 380, in _on_orig_load_finished
if preview.create_thumbnail(data):
File "C:\Users\Simona\Gajim-Portable-Master-64bit-2021-05-14\UserData\Plugins\url_image_preview\url_image_preview.py", line 819, in create_thumbnail
self.thumbnail = create_thumbnail(data, self.size)
File "C:\Users\Simona\Gajim-Portable-Master-64bit-2021-05-14\UserData\Plugins\url_image_preview\utils.py", line 129, in create_thumbnail
thumbnail = create_thumbnail_with_pil(data, size)
File "C:\Users\Simona\Gajim-Portable-Master-64bit-2021-05-14\UserData\Plugins\url_image_preview\utils.py", line 181, in create_thumbnail_with_pil
resize_gif(image, output_file, (size, size))
File "C:\Users\Simona\Gajim-Portable-Master-64bit-2021-05-14\UserData\Plugins\url_image_preview\utils.py", line 44, in resize_gif
frames, result = extract_and_resize_frames(image, resize_to)
File "C:\Users\Simona\Gajim-Portable-Master-64bit-2021-05-14\UserData\Plugins\url_image_preview\utils.py", line 99, in extract_and_resize_frames
if not image.getpalette():
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.8/site-packages/PIL/Image.py", line 1360, in getpalette
File "C:/msys64/home/appveyor/gajim/win/_build_root/mingw64/lib/python3.8/site-packages/PIL/ImageFile.py", line 249, in load
OSError: image file is truncated (5 bytes not processed)
```
## Steps to reproduce the problem
1) start Gajim
2) peng !
...https://dev.gajim.org/gajim/gajim-plugins/-/issues/570[preview] Add warning before opening potentially dangerous executables2021-12-06T08:37:48ZDaniel Brötzmann[preview] Add warning before opening potentially dangerous executablesAdd a warning before opening potentially dangerous executables.
* Windows: exe, bat, ...Add a warning before opening potentially dangerous executables.
* Windows: exe, bat, ...https://dev.gajim.org/gajim/gajim-plugins/-/issues/571[preview] Gajim freezes when a certain gif is posted2021-12-06T08:37:37ZM-i-k-o-t-o[preview] Gajim freezes when a certain gif is posted## Versions
- OS: Debian sid
- Gajim version: 1.3.3-1
- Plugin version: gajim-urlimagepreview 2.5.6-2 and gajim-omemo 2.7.13-1
- GTK version: 3.24.30-3
- Python-nbxmpp version: 2.0.4-1
All of the above were installed using D...## Versions
- OS: Debian sid
- Gajim version: 1.3.3-1
- Plugin version: gajim-urlimagepreview 2.5.6-2 and gajim-omemo 2.7.13-1
- GTK version: 3.24.30-3
- Python-nbxmpp version: 2.0.4-1
All of the above were installed using Debian's sid repositories.
## Steps to reproduce the problem
1. upload this gif: https://bun.filedit.ch/QgIavfIEmPvfWZfcCPPw.gif
## Actual behavior
Gajim freezes and I have to pkill -9 it.
## Notes
I only tested it with omemo enabled. My friend with windows 7 and gajim 1.3.2 could not reproduce, my other friend with guixsd and gajim 1.3.2 could not reproduce either.https://dev.gajim.org/gajim/gajim-plugins/-/issues/410[syntax_highlight] Support XHTML based markup2021-12-04T23:03:30ZFlorian Münchbach[syntax_highlight] Support XHTML based markup* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
In a discussion in gajim@conference.gajim.org, the wish for syntax highlighting with XHTML based markup came up.
Possible XEPs:
* [XEP-0071 (XHTML-IM)]...* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
In a discussion in gajim@conference.gajim.org, the wish for syntax highlighting with XHTML based markup came up.
Possible XEPs:
* [XEP-0071 (XHTML-IM)](https://xmpp.org/extensions/xep-0071.html), (state: deprecated, supported by gajim)
* [XEP-0394 (Message Markup)](https://xmpp.org/extensions/xep-0394.html), (state: deferred, not supported by gajim)
excerpts from discussion in gajim@conference.gajim.org (2019-02-28):
> for incoming text xhtml should have priority, if it is in the received message and enabled on receiver's side. if either does not apply, the plain text + markup should be used
> the generally recommended way for code is `<pre><code class="language-python">print('Hello world!')</code></pre>`, and that’s what poezio sends (with coloured spans inside, but that you can ignore if you do your own rendering).https://dev.gajim.org/gajim/gajim-plugins/-/issues/409[syntax_highlight] Code highlighting in message textview (sender's side)2021-12-04T23:03:25ZFlorian Münchbach[syntax_highlight] Code highlighting in message textview (sender's side)* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
So far, code (blocks and spans) is highlighted in the view for received messages only. Sending still requires manually typing the back-ticks markup dire...* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
So far, code (blocks and spans) is highlighted in the view for received messages only. Sending still requires manually typing the back-ticks markup directives, which is not very comfortable. Plus, syntax highlighting is not applied to the text input at all.
The plugin should highlight code during input, too. Highlighting should start as soon as an opening code element is found in the input field until the element is closed or aborted (e.g. by another block or an invalid character, such as a newline).
ToDo:
* [ ] Implement highlighting "on-demand"
* [ ] Add buttons for inserting inline code spans or blocks
* [ ] If [XEP-0071 (XHTML-IM)](https://xmpp.org/extensions/xep-0071.html) is used, add both XHTML and [XEP-0303 (Message Styling)](https://xmpp.org/extensions/xep-0393.html)-style markup
* [ ] Extension/Nice to have: Reuse the code widget (see #408)
* TBD: how/when to replace plain text input without disturbing or surprising the user?
* When appropriate: respect config options defined in #408
* TBD: how/when should we serialize back to "normal" markuphttps://dev.gajim.org/gajim/gajim-plugins/-/issues/408[syntax_highlight] Code widget in chat textview2021-12-04T23:02:39ZFlorian Münchbach[syntax_highlight] Code widget in chat textview* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
Instead of using the current text-only highlighting inside the chat textview using a custom widget offers more styling options and better usability.
Sc...* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
Instead of using the current text-only highlighting inside the chat textview using a custom widget offers more styling options and better usability.
Screenshot of a recent draft:
![screenshot](/uploads/d8c8730f4b8cdf3887ca03e186ef428a/screenshot.png)
* [x] create a code widget
* [x] show line numbers, identify wrapped lines
* [ ] (partial) add copy/quote buttons (see #407)
* [x] add display of currently selected language
* [ ] add a way to change the current language
* [x] add config dialog option to switch between current text-only and widget views
* [ ] add config dialog option to change widget width **or** automatically adapt to window width (<- seems to create more issues than it solves in first tests...)
Extension (just to capture the thought here): allow line number offsetGajim 1.4.0Florian MünchbachFlorian Münchbachhttps://dev.gajim.org/gajim/gajim-plugins/-/issues/407[syntax_highlight] Add "copy" and "quote" commands for code blocks2021-12-04T23:02:28ZFlorian Münchbach[syntax_highlight] Add "copy" and "quote" commands for code blocks* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
Code (blocks and inline spans) have to be selected manually in order to be copied. It would be nice to have a simple way to copy or cite code blocks.
Im...* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
Code (blocks and inline spans) have to be selected manually in order to be copied. It would be nice to have a simple way to copy or cite code blocks.
Implementation could add entries to the context (right-click) menu.Gajim 1.4.0https://dev.gajim.org/gajim/gajim-plugins/-/issues/405[syntax_highlight] Support for mixed/inlined markup directives in inline code...2021-12-04T23:02:16ZFlorian Münchbach[syntax_highlight] Support for mixed/inlined markup directives in inline code spans* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
The plugin should be able to handle different inlined markup directives, as [defined in XEP-0393, 5.2.5 Preformatted Span](https://xmpp.org/extensions/x...* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
The plugin should be able to handle different inlined markup directives, as [defined in XEP-0393, 5.2.5 Preformatted Span](https://xmpp.org/extensions/xep-0393.html#mono), e.g.:
```
*`print('hello, wold')`*
```
should be rendered as
> **`print('hello, wold')`**
TBD: The above works best with the highlighting language being pure monospace. If this is not the case and/or the highlighting of the code span would contradict the outer formatting directives, it should be discussed how the outer formatting is treated.
Imho, the user's explicitly expressed wish for an additional formatting should be honored and the highlighter's output should be overridden where it does not (yet) match the user's formatting.Gajim 1.4.0https://dev.gajim.org/gajim/gajim-plugins/-/issues/406[syntax_highlight] Inline code spans not highlighted if followed by punctuation2021-12-04T23:02:03ZFlorian Münchbach[syntax_highlight] Inline code spans not highlighted if followed by punctuation* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
Currently, the plugin matches (and formats) inline code spans only if pre-/succeeded by whitespaces, including newlines.
This leads to unexpected non-fo...* Gajim Version: 1.1.2 / master
* Plugin Version: >= 1.0.0
* Operating System: all
Currently, the plugin matches (and formats) inline code spans only if pre-/succeeded by whitespaces, including newlines.
This leads to unexpected non-formatted code spans if, for instance, followed by a comma.
Hence, the plugin should not only allow whitespaces to surround code spans, but also any of the following characters as long as they are not part of another markup formatting directive (see: #405).
Allowed punctuation characters:
* comma: `,`
* quotation marks ("fancy" ones, incl. guillements, too?!): `"'‘’“”‹›«»`
* end marks: `.?!`; plus their spanish "begin" counterparts: `¡¿`
* colon + semicolon: `:;`
* brackets: `{}[]()<>`
* ellipses: `… ... . . .`
* others: `-_*~`
Quite a lot already. I guess, this should cover most cases in many languages where punctuation is needed directly before/after code spans. Since I don't know them all, please add more characters that you might need/want in the comments.Gajim 1.4.0https://dev.gajim.org/gajim/gajim-plugins/-/issues/491SyntaxHighlight: Indent the whole codeblock2021-12-04T23:01:50ZPhilipp Höristphilipp@hoerist.comSyntaxHighlight: Indent the whole codeblock## Description of the new feature
It would be nice if the whole codeblock is indented by something like one tab or a few spaces
This could be achived by adding a texttag with the property left-margin## Description of the new feature
It would be nice if the whole codeblock is indented by something like one tab or a few spaces
This could be achived by adding a texttag with the property left-marginGajim 1.4.0https://dev.gajim.org/gajim/gajim-plugins/-/issues/531Birthday reminder causes traceback on startup2021-12-04T23:00:51ZGhost UserBirthday reminder causes traceback on startup## Versions
- OS: Windows 10
- GTK Version: 3.24.20
- PyGObject Version: 3.36.1
- GLib Version : 2.64.1
- python-nbxmpp Version: 1.0.1
- Gajim Version: 1.2.1
## Traceback
```
Traceback (most recent call last):
File "C:\Users\Noah Keck...## Versions
- OS: Windows 10
- GTK Version: 3.24.20
- PyGObject Version: 3.36.1
- GLib Version : 2.64.1
- python-nbxmpp Version: 1.0.1
- Gajim Version: 1.2.1
## Traceback
```
Traceback (most recent call last):
File "C:\Users\Noah Keck\AppData\Roaming\Gajim\Plugins\birthday_reminder\plugin.py", line 108, in _check_birthdays_at_start
self._check_birthdays()
File "C:\Users\Noah Keck\AppData\Roaming\Gajim\Plugins\birthday_reminder\plugin.py", line 116, in _check_birthdays
account, contact = self._find_contact(jid)
File "C:\Users\Noah Keck\AppData\Roaming\Gajim\Plugins\birthday_reminder\plugin.py", line 141, in _find_contact
return account, contact[0]
IndexError: list index out of range
```
## Steps to reproduce the problem
...
1. Install the "Birthday reminder" plugin
2. Start up Gajim on latest Windows 10
There seems to be no clear trigger on my end, I simply keep getting this dialog immediately on startup no matter what. On ubuntu this appears to work fine.Gajim 1.4.0https://dev.gajim.org/gajim/gajim-plugins/-/issues/548[appindicator_integration] New message icon not shown2021-12-04T23:00:39ZArno Onken[appindicator_integration] New message icon not shown## Versions
- OS: GNU/Linux Debian Sid
- Gajim version: 1.3.0
- Plugin version: 1.3.3
- GTK version: 3.24.24
- Glib version: 2.66.2
- PyGObject version: 3.38.0
- Python-nbxmpp version: 2.0.2
- Sway version: 1.5.1
- Wa...## Versions
- OS: GNU/Linux Debian Sid
- Gajim version: 1.3.0
- Plugin version: 1.3.3
- GTK version: 3.24.24
- Glib version: 2.66.2
- PyGObject version: 3.38.0
- Python-nbxmpp version: 2.0.2
- Sway version: 1.5.1
- Waybar version: 0.9.5
## Steps to reproduce the problem
1. Start Gajim with appindicator_integration plugin active.
2. Receive a message while Gajim is in the background.
3. Read the message.
## Expected behavior
When the message is received, the tray icon should change from "online" to "new-message" and back to "online" once the message is read.
## Actual behavior
The icon remains at "online" without changing.
The ```self.indicator.set_status(appindicator.IndicatorStatus.ATTENTION)``` seems to not trigger an icon change.
## Solution
In ```plugin.py```, changing
```
self.indicator.set_status(appindicator.IndicatorStatus.ATTENTION)
```
to
```
self.indicator.set_status(appindicator.IndicatorStatus.ATTENTION)
self.indicator.set_icon_full('mail-unread', 'New Message')
```
and adding
```
if self.connected == 1:
self.indicator.set_icon_full(self.online_icon, _('Online'))
else:
self.indicator.set_icon_full(self.offline_icon, _('Offline'))
```
to the end of the file fixes the problem for me. These should be harmless changes making the plugin more robust.Gajim 1.4.0