From c0178db779d8a6f25f986b7609174b3672519b5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20H=C3=B6rist?= <philipp@hoerist.com>
Date: Sat, 16 Feb 2019 10:36:27 +0100
Subject: [PATCH] Redirect some print statments to stderr
Otherwise they errors will not show up if the console output is
redirected to a file
---
gajim/common/i18n.py | 8 ++++----
gajim/common/logging_helpers.py | 5 +++--
gajim/gtkexcepthook.py | 2 +-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/gajim/common/i18n.py b/gajim/common/i18n.py
index 5e81af36e1..2d0fc4686a 100644
--- a/gajim/common/i18n.py
+++ b/gajim/common/i18n.py
@@ -151,7 +151,7 @@ def ngettext(s_sing, s_plural, n, replace_sing=None, replace_plural=None):
try:
locale.setlocale(locale.LC_ALL, '')
except locale.Error as error:
- print(error)
+ print(error, file=sys.stderr)
try:
LANG = get_default_lang()
@@ -161,7 +161,7 @@ try:
os.environ['LANG'] = LANG
print('Found default language: %s' % LANG)
except Exception as error:
- print('Failed to determine default language')
+ print('Failed to determine default language', file=sys.stderr)
import traceback
traceback.print_exc()
@@ -177,6 +177,6 @@ for dir_ in iter_locale_dirs():
else:
break
else:
- print('No translations found')
- print('Dirs searched: %s' % get_locale_dirs())
+ print('No translations found', file=sys.stderr)
+ print('Dirs searched: %s' % get_locale_dirs(), file=sys.stderr)
_ = _translation.gettext
diff --git a/gajim/common/logging_helpers.py b/gajim/common/logging_helpers.py
index ea6321e0b4..3853666f9c 100644
--- a/gajim/common/logging_helpers.py
+++ b/gajim/common/logging_helpers.py
@@ -28,7 +28,7 @@ def parseLogLevel(arg):
return int(arg)
if arg.isupper() and hasattr(logging, arg):
return getattr(logging, arg)
- print(_('%s is not a valid loglevel') % repr(arg))
+ print(_('%s is not a valid loglevel') % repr(arg), file=sys.stderr)
return 0
def parseLogTarget(arg):
@@ -69,7 +69,8 @@ def parseAndSetLogLevels(arg):
target = parseLogTarget(target.strip())
if target:
logging.getLogger(target).setLevel(level)
- print("Logger %s level set to %d" % (target, level))
+ print("Logger %s level set to %d" % (target, level),
+ file=sys.stderr)
class colors:
diff --git a/gajim/gtkexcepthook.py b/gajim/gtkexcepthook.py
index 963717f390..62ddca2920 100644
--- a/gajim/gtkexcepthook.py
+++ b/gajim/gtkexcepthook.py
@@ -85,7 +85,7 @@ class ExceptionDialog():
traceback.print_exception(type_, value, tb, None, trace)
self.text = self.get_issue_text(trace.getvalue())
buffer_.set_text(self.text)
- print(self.text)
+ print(self.text, file=sys.stderr)
self.exception_view.set_editable(False)
self.dialog.show()
if __name__ == '__main__':
--
GitLab