diff --git a/src/common/dataforms.py b/src/common/dataforms.py index c046e76fc2490d8a3c87673068d429c2cd32924c..afbc7951bf9e247bcc6c4a9adb2fef54b4d30057 100644 --- a/src/common/dataforms.py +++ b/src/common/dataforms.py @@ -48,7 +48,9 @@ def Field(typ, **attrs): def ExtendField(node): ''' Helper function to extend a node to field of appropriate type. ''' - # TODO: move the dict out + # when validation (XEP-122) will go in, we could have another classes + # like DateTimeField - so that dicts in Field() and ExtendField() will + # be different... typ=node.getAttr('type') f = { 'boolean': BooleanField, @@ -216,7 +218,7 @@ class ListField(DataField): return locals() def iter_options(self): - for element in self.getTags('option'): # TODO: iter! + for element in self.iterTags('option'): v = element.getTagData('value') if v is None: raise WrongFieldValue yield (v, element.getAttr('label')) @@ -254,7 +256,7 @@ class TextMultiField(DataField): '''Value held in field.''' def fget(self): value = u'' - for element in self.getTags('value'): # TODO: iter! + for element in self.iterTags('value'): value += '\n' + element.getData() return value[1:] def fset(self, value): @@ -282,7 +284,7 @@ class DataRecord(ExtendedNode): # we already have xmpp.Node inside - try to convert all # fields into DataField objects if fields is None: - for field in self.getTags('field'): # TODO: iter! + for field in self.iterTags('field'): if not isinstance(field, DataField): ExtendField(field) self.vars[field.var] = field @@ -310,7 +312,7 @@ class DataRecord(ExtendedNode): def iter_fields(self): ''' Iterate over fields in this record. Do not take associated into account. ''' - for field in self.getTags('field'): # TODO: iter! + for field in self.iterTags('field'): yield field def iter_with_associated(self): diff --git a/src/common/xmpp/simplexml.py b/src/common/xmpp/simplexml.py index 014134e8346fb8ef94478c5ebd34dd36c66ca7d7..aff4120cd12184cb48459b979c1f073d87d73ede 100644 --- a/src/common/xmpp/simplexml.py +++ b/src/common/xmpp/simplexml.py @@ -200,8 +200,8 @@ class Node(object): for key in attrs.keys(): if not node.attrs.has_key(key) or \ node.attrs[key]!=attrs[key]: break - else: - yield node + else: + yield node def setAttr(self, key, val): """ Sets attribute "key" with the value "val". """ diff --git a/src/dataforms_widget.py b/src/dataforms_widget.py index 7b92fa422b3918d2f25ca92d22c5bcafc4c844a5..c53992dab6e0b64df7d71b353ca5a451774c3fdb 100644 --- a/src/dataforms_widget.py +++ b/src/dataforms_widget.py @@ -76,7 +76,7 @@ class DataFormWidget(gtk.Alignment, object): # form is single instructions = _('This is result of query.') else: - # form is writable (TODO: move that to build_*_data_form()? + # form is writable (TODO: move that to build_*_data_form()?) if isinstance(dataform, dataforms.SimpleDataForm): instructions = _('Fill in the form.') else: