From f6c3d03261bfd5ff4b93c50c0736f9bdee96edda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Br=C3=B6tzmann?= Date: Fri, 26 Apr 2019 17:09:18 +0200 Subject: [PATCH] Rework SingleMessageWindow --- gajim/data/gui/single_message_window.ui | 282 +++++++++++++++++------- gajim/gtk/single_message.py | 213 +++++++++--------- 2 files changed, 310 insertions(+), 185 deletions(-) diff --git a/gajim/data/gui/single_message_window.ui b/gajim/data/gui/single_message_window.ui index c7c704cce..3e03e7257 100644 --- a/gajim/data/gui/single_message_window.ui +++ b/gajim/data/gui/single_message_window.ui @@ -1,49 +1,59 @@ - + - + True False - gtk-ok + mail-reply-sender-symbolic True False - gtk-ok + mail-send-symbolic True False - gtk-jump-to + mail-send-symbolic + + + True + False + user-info-symbolic False - 6 - 550 - 280 - + + + + True False + 18 vertical - 6 - + True False - 3 - 3 + True + 6 + 12 - + True False - True - 0 - From: + end + _To + True + to_entry + 0 @@ -51,124 +61,239 @@ - + True - False - True - 0 - To: + True + True + user@example.org - 0 - 1 + 1 + 0 - + True False - Subject: + end + Su_bject + True + subject_entry + True + 0 - 2 + 1 - + True True - True - True + Type the subject here... + True 1 - 0 + 1 2 - + True - True - True - True + False + end + _Message + True + message_textview + - 1 - 1 - 2 + 0 + 2 - + + 100 True True - True + True + in + + + True + True + word-char + 6 + 6 + 6 + 6 + + 1 2 + 2 True False - 0 + end + Characters typed: 0 + + + + 0 + 3 + 3 + + + + + True + False + True + True + Query Contact Info + image4 + 2 - 2 + 0 - False + True True 0 - + True - True + False True - in + 6 + 12 - + + True + False + end + _From + True + + + + 0 + 0 + + + + + True + False + end + Subject + + + + 0 + 1 + + + + + True + False + <user@example.org> + 0 + + + + 1 + 0 + + + + + True + False + <from Subject> + True + 50 + 0 + + + 1 + 1 + - - - True - True - 1 - - - - - True - True - True - in - + + 100 True True - word + True + True + in + + + + + 1 + 2 + + + + + True + False + end + Message + + + + 0 + 2 + True True - 2 + 1 - + True False + 12 12 end @@ -188,23 +313,6 @@ 0 - - - gtk-cancel - True - True - True - False - True - True - - - - False - False - 1 - - Sen_d @@ -214,7 +322,7 @@ False True Send message - image3 + image2 True @@ -236,6 +344,9 @@ image1 True + False @@ -252,9 +363,12 @@ False True Send message and close window - image2 + image3 True + False @@ -267,7 +381,7 @@ False True 6 - 3 + 4 diff --git a/gajim/gtk/single_message.py b/gajim/gtk/single_message.py index 338b71848..69f08cf13 100644 --- a/gajim/gtk/single_message.py +++ b/gajim/gtk/single_message.py @@ -16,7 +16,9 @@ from typing import List # pylint: disable=unused-import from gi.repository import Gdk from gi.repository import GLib +from gi.repository import Gtk +from gajim import vcard from gajim.common import app from gajim.common import helpers from gajim.common.i18n import _ @@ -37,16 +39,17 @@ if app.is_installed('GSPELL'): from gi.repository import Gspell # pylint: disable=ungrouped-imports -class SingleMessageWindow: +class SingleMessageWindow(Gtk.ApplicationWindow): """ SingleMessageWindow can send or show a received singled message depending on action argument which can be 'send' or 'receive' """ - # Keep a reference on windows so garbage collector don't restroy them - instances = [] # type: List[SingleMessageWindow] def __init__(self, account, to='', action='', from_whom='', subject='', message='', resource='', session=None, form_node=None): - self.instances.append(self) + Gtk.ApplicationWindow.__init__(self) + self.set_application(app.app) + self.set_title(_('Send Single Message')) + self.set_name('SendSingleMessageWindow') self.account = account self.action = action @@ -57,51 +60,38 @@ class SingleMessageWindow: self.resource = resource self.session = session - self.xml = get_builder('single_message_window.ui') - self.window = self.xml.get_object('single_message_window') - self.count_chars_label = self.xml.get_object('count_chars_label') - self.from_label = self.xml.get_object('from_label') - self.from_entry = self.xml.get_object('from_entry') - self.to_label = self.xml.get_object('to_label') - self.to_entry = self.xml.get_object('to_entry') - self.subject_entry = self.xml.get_object('subject_entry') - self.message_scrolledwindow = self.xml.get_object( - 'message_scrolledwindow') - self.message_textview = self.xml.get_object('message_textview') - self.message_tv_buffer = self.message_textview.get_buffer() - self.conversation_scrolledwindow = self.xml.get_object( - 'conversation_scrolledwindow') + self._ui = get_builder('single_message_window.ui') + self.message_tv_buffer = self._ui.message_textview.get_buffer() self.conversation_textview = ConversationTextview( account, used_in_history_window=True) self.conversation_textview.tv.show() + self.conversation_textview.tv.set_left_margin(6) + self.conversation_textview.tv.set_right_margin(6) + self.conversation_textview.tv.set_top_margin(6) + self.conversation_textview.tv.set_bottom_margin(6) self.conversation_tv_buffer = self.conversation_textview.tv.get_buffer() - self.xml.get_object('conversation_scrolledwindow').add( - self.conversation_textview.tv) + self._ui.conversation_scrolledwindow.add( + self.conversation_textview.tv) self.form_widget = None - parent_box = self.xml.get_object('conversation_scrolledwindow').\ - get_parent() + parent_box = self._ui.conversation_scrolledwindow.get_parent() if form_node: self.form_widget = DataFormWidget(form_node) self.form_widget.show_all() + self._ui.conversation_scrolledwindow.hide() + self._ui.message_label_received.hide() parent_box.add(self.form_widget) - parent_box.child_set_property(self.form_widget, 'position', - parent_box.child_get_property(self.xml.get_object( - 'conversation_scrolledwindow'), 'position')) + parent_box.child_set_property(self.form_widget, 'top-attach', 2) + parent_box.child_set_property(self.form_widget, 'left-attach', 0) + parent_box.child_set_property(self.form_widget, 'width', 2) self.action = 'form' - self.send_button = self.xml.get_object('send_button') - self.reply_button = self.xml.get_object('reply_button') - self.send_and_close_button = self.xml.get_object('send_and_close_button') - self.cancel_button = self.xml.get_object('cancel_button') - self.close_button = self.xml.get_object('close_button') self.message_tv_buffer.connect('changed', self.update_char_counter) if isinstance(to, list): jid = ', '.join([i[0].get_full_jid() for i in to]) - self.to_entry.set_text(jid) - self.to_entry.set_sensitive(False) + self._ui.to_entry.set_text(jid) else: - self.to_entry.set_text(to) + self._ui.to_entry.set_text(to) if app.config.get('use_speller') and app.is_installed('GSPELL') and action == 'send': lang = app.config.get('speller_language') @@ -110,10 +100,10 @@ class SingleMessageWindow: AspellDictError(lang) else: spell_buffer = Gspell.TextBuffer.get_from_gtk_text_buffer( - self.message_textview.get_buffer()) + self._ui.message_textview.get_buffer()) spell_buffer.set_spell_checker(Gspell.Checker.new(gspell_lang)) spell_view = Gspell.TextView.get_from_gtk_text_view( - self.message_textview) + self._ui.message_textview) spell_view.set_inline_spell_checking(True) spell_view.set_enable_language_menu(True) @@ -121,12 +111,12 @@ class SingleMessageWindow: # set_text(None) raises TypeError exception if self.subject is None: - self.subject = '' - self.subject_entry.set_text(self.subject) - + self.subject = _('(No subject)') + self._ui.subject_entry.set_text(self.subject) + self._ui.subject_from_entry_label.set_text(self.subject) if to == '': - liststore = get_completion_liststore(self.to_entry) + liststore = get_completion_liststore(self._ui.to_entry) self.completion_dict = helpers.get_contact_dict_for_account(account) keys = sorted(self.completion_dict.keys()) for jid in keys: @@ -135,20 +125,21 @@ class SingleMessageWindow: liststore.append((status_icon, jid)) else: self.completion_dict = {} - self.xml.connect_signals(self) + + self._ui.to_entry.connect('changed', self.on_to_entry_changed) + self._ui.connect_signals(self) # get window position and size from config - resize_window(self.window, + resize_window(self._ui.single_message_window, app.config.get('single-msg-width'), app.config.get('single-msg-height')) - move_window(self.window, + move_window(self._ui.single_message_window, app.config.get('single-msg-x-position'), app.config.get('single-msg-y-position')) - self.window.show_all() + self._ui.single_message_window.show_all() def on_single_message_window_destroy(self, widget): - self.instances.remove(self) c = app.contacts.get_contact_with_highest_priority(self.account, self.from_whom) if not c: @@ -166,16 +157,44 @@ class SingleMessageWindow: def save_pos(self): # save the window size and position - x, y = self.window.get_position() + x, y = self._ui.single_message_window.get_position() app.config.set('single-msg-x-position', x) app.config.set('single-msg-y-position', y) - width, height = self.window.get_size() + width, height = self._ui.single_message_window.get_size() app.config.set('single-msg-width', width) app.config.set('single-msg-height', height) def on_single_message_window_delete_event(self, window, ev): self.save_pos() + def on_show_contact_info_button_clicked(self, widget): + """ + Ask for vCard + """ + entry = self._ui.to_entry.get_text().strip() + + keys = sorted(self.completion_dict.keys()) + for key in keys: + contact = self.completion_dict[key] + if entry in key: + entry = contact.jid + break + + if entry in app.interface.instances[self.account]['infos']: + app.interface.instances[self.account]['infos'][entry].window.present() + else: + contact = app.contacts.create_contact(jid=entry, account=self.account) + app.interface.instances[self.account]['infos'][entry] = \ + vcard.VcardWindow(contact, self.account) + # Remove xmpp page + app.interface.instances[self.account]['infos'][entry].xml.\ + get_object('information_notebook').remove_page(0) + + def on_to_entry_changed(self, widget): + entry = self._ui.to_entry.get_text() + is_empty = bool(not entry == '' and not ',' in entry) + self._ui.show_contact_info_button.set_sensitive(is_empty) + def prepare_widgets_for(self, action): if len(app.connections) > 1: if action == 'send': @@ -187,75 +206,67 @@ class SingleMessageWindow: if action == 'send': # prepare UI for Sending title = _('Send %s') % title - self.send_button.show() - self.send_and_close_button.show() - self.to_label.show() - self.to_entry.show() - self.reply_button.hide() - self.from_label.hide() - self.from_entry.hide() - self.conversation_scrolledwindow.hide() - self.message_scrolledwindow.show() + self._ui.send_button.show() + self._ui.send_and_close_button.show() + self._ui.reply_button.hide() + self._ui.close_button.hide() + + self._ui.send_grid.show() + self._ui.received_grid.hide() if self.message: # we come from a reply? - self.message_textview.grab_focus() - self.cancel_button.hide() - self.close_button.show() + self._ui.show_contact_info_button.set_sensitive(True) + self._ui.message_textview.grab_focus() self.message_tv_buffer.set_text(self.message) GLib.idle_add(self.set_cursor_to_end) else: # we write a new message (not from reply) - self.close_button.hide() if self.to: # do we already have jid? - self.subject_entry.grab_focus() + self._ui.subject_entry.grab_focus() elif action == 'receive': # prepare UI for Receiving title = _('Received %s') % title - self.reply_button.show() - self.from_label.show() - self.from_entry.show() - self.send_button.hide() - self.send_and_close_button.hide() - self.to_label.hide() - self.to_entry.hide() - self.conversation_scrolledwindow.show() - self.message_scrolledwindow.hide() + self._ui.reply_button.show() + self._ui.close_button.show() + self._ui.send_button.hide() + self._ui.send_and_close_button.hide() + self._ui.reply_button.grab_focus() + + self._ui.received_grid.show() + self._ui.send_grid.hide() if self.message: self.conversation_textview.print_real_text(self.message) fjid = self.from_whom if self.resource: fjid += '/' + self.resource # Full jid of sender (with resource) - self.from_entry.set_text(fjid) - self.from_entry.set_property('editable', False) - self.subject_entry.set_property('editable', False) - self.reply_button.grab_focus() - self.cancel_button.hide() - self.close_button.show() + self._ui.from_entry_label.set_text(fjid) + elif action == 'form': # prepare UI for Receiving - title = _('Form %s') % title - self.send_button.show() - self.send_and_close_button.show() - self.to_label.show() - self.to_entry.show() - self.reply_button.hide() - self.from_label.hide() - self.from_entry.hide() - self.conversation_scrolledwindow.hide() - self.message_scrolledwindow.hide() - - self.window.set_title(title) - - def on_cancel_button_clicked(self, widget): - self.save_pos() - self.window.destroy() + title = self.form_widget.title + title = _('Form: %s') % title + self._ui.send_button.hide() + self._ui.send_and_close_button.hide() + self._ui.reply_button.show() + self._ui.close_button.show() + + self._ui.send_grid.hide() + self._ui.received_grid.show() + + fjid = self.from_whom + if self.resource: + fjid += '/' + self.resource # Full jid of sender (with resource) + self._ui.from_entry_label.set_text(fjid) + + self._ui.single_message_window.set_title(title) def on_close_button_clicked(self, widget): self.save_pos() - self.window.destroy() + self._ui.single_message_window.destroy() def update_char_counter(self, widget): characters_no = self.message_tv_buffer.get_char_count() - self.count_chars_label.set_text(str(characters_no)) + self._ui.count_chars_label.set_text( + _('Characters typed: %s') % str(characters_no)) def send_single_message(self): if app.connections[self.account].connected <= 1: @@ -271,10 +282,10 @@ class SingleMessageWindow: else: sender_list.append(i[0].jid) else: - sender_list = [j.strip() for j in self.to_entry.get_text().split( + sender_list = [j.strip() for j in self._ui.to_entry.get_text().split( ',')] - subject = self.subject_entry.get_text() + subject = self._ui.subject_entry.get_text() begin, end = self.message_tv_buffer.get_bounds() message = self.message_tv_buffer.get_text(begin, end, True) @@ -292,8 +303,8 @@ class SingleMessageWindow: to_whom_jid = helpers.parse_jid(to_whom_jid) except helpers.InvalidFormat: ErrorDialog(_('Invalid JID'), - _('It is not possible to send a message to %s, this JID is not ' - 'valid.') % to_whom_jid) + _('It is not possible to send a message to %s, this JID ' + 'is not valid.') % to_whom_jid) return True if '/announce/' in to_whom_jid: @@ -307,7 +318,7 @@ class SingleMessageWindow: account=self.account, jid=recipient_list, message=message, type_='normal', subject=subject, form_node=form_node)) - self.subject_entry.set_text('') # we sent ok, clear the subject + self._ui.subject_entry.set_text('') # we sent ok, clear the subject self.message_tv_buffer.set_text('') # we sent ok, clear the textview def on_send_button_clicked(self, widget): @@ -319,7 +330,7 @@ class SingleMessageWindow: self.message = _('%s wrote:\n') % self.from_whom + self.message # add > at the begining of each line self.message = self.message.replace('\n', '\n> ') + '\n\n' - self.window.destroy() + self._ui.single_message_window.destroy() SingleMessageWindow(self.account, to=self.from_whom, action='send', from_whom=self.from_whom, subject=self.subject, message=self.message, session=self.session) @@ -328,9 +339,9 @@ class SingleMessageWindow: if self.send_single_message(): return self.save_pos() - self.window.destroy() + self._ui.single_message_window.destroy() def on_single_message_window_key_press_event(self, widget, event): if event.keyval == Gdk.KEY_Escape: # ESCAPE self.save_pos() - self.window.destroy() + self._ui.single_message_window.destroy() -- GitLab